Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 45733010: Add pointer-events="bounding-box" for svg content. (Closed)

Created:
7 years, 1 month ago by Erik Dahlström (inactive)
Modified:
7 years ago
CC:
blink-reviews, eustas+blink_chromium.org, caseq+blink_chromium.org, loislo+blink_chromium.org, zoltan1, devtools-reviews_chromium.org, alph+blink_chromium.org, eae+blinkwatch, leviw+renderwatch, lushnikov+blink_chromium.org, yurys+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, dglazkov+blink, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, jchaffraix+rendering, darktears, pdr, f(malita), Stephen Chennney, aandrey+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Add pointer-events="bounding-box" for svg content. The 'bounding-box' keyword in 'pointer-events' enables svg authors to leave out certain invisible 'hit-area' elements, and instead get them generated based on the bounding box. This is convenient for example if one wants multiline text in svg to respond to mouse events over the entire region it covers. Another common use-case is groups, which are container elements. These elements currently are not possible to target directly, since they only get events through bubbling from their children. This patch makes container elements targetable if one specifies 'pointer-events: bounding-box' on them (either as an svg presentation attribute or in css). The 'bounding-box' keyword is specified in SVG2, https://svgwg.org/svg2-draft/interact.html#PointerEventsProp. Note: The keyword was called 'boundingbox' in SVG Tiny 1.2, http://www.w3.org/TR/SVGTiny12/interact.html#PointerEventsProperty, but it was renamed to be more in sync with CSS syntax in general. R=pdr BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=163425

Patch Set 1 #

Total comments: 11

Patch Set 2 : review fixups #

Patch Set 3 : lowercase boundingBox #

Total comments: 2

Patch Set 4 : 'boundingbox' -> 'bounding-box' #

Patch Set 5 : rebased #

Patch Set 6 : make assert more specific #

Unified diffs Side-by-side diffs Delta from patch set Stats (+296 lines, -10 lines) Patch
A LayoutTests/svg/hittest/svg-pointer-events-bbox.html View 1 2 3 1 chunk +221 lines, -0 lines 0 comments Download
A LayoutTests/svg/hittest/svg-pointer-events-bbox-expected.txt View 1 2 3 1 chunk +38 lines, -0 lines 0 comments Download
M Source/core/css/CSSParser-in.cpp View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/css/CSSPrimitiveValueMappings.h View 1 2 3 4 5 2 chunks +5 lines, -0 lines 0 comments Download
M Source/core/css/CSSValueKeywords.in View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/rendering/PointerEventsHitRules.h View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/rendering/PointerEventsHitRules.cpp View 1 2 3 4 3 chunks +7 lines, -0 lines 0 comments Download
M Source/core/rendering/style/RenderStyleConstants.h View 1 2 3 4 5 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/rendering/svg/RenderSVGContainer.cpp View 1 2 3 4 5 1 chunk +8 lines, -1 line 0 comments Download
M Source/core/rendering/svg/RenderSVGImage.cpp View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/svg/RenderSVGShape.cpp View 1 2 3 4 5 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/rendering/svg/RenderSVGText.cpp View 1 2 3 4 5 1 chunk +4 lines, -1 line 0 comments Download
M Source/core/rendering/svg/SVGInlineTextBox.cpp View 1 2 3 4 5 1 chunk +2 lines, -1 line 0 comments Download
M Source/devtools/front_end/CSSMetadata.js View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/cm/css.js View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 24 (0 generated)
Erik Dahlström (inactive)
7 years, 1 month ago (2013-10-31 10:18:45 UTC) #1
pdr.
Implementation-wise, this is a great patch. It looks like the SVGWG has not added support ...
7 years, 1 month ago (2013-11-01 03:41:59 UTC) #2
krit
On 2013/11/01 03:41:59, pdr wrote: > Implementation-wise, this is a great patch. > > It ...
7 years, 1 month ago (2013-11-01 05:49:00 UTC) #3
Erik Dahlström (inactive)
The SVG WG resolved at TPAC 2013 to add pointer-events=boundingbox to SVG2, see http://www.w3.org/2013/11/15-svg-minutes.html#item13. Spec ...
7 years, 1 month ago (2013-11-22 13:11:03 UTC) #4
pdr.
On 2013/11/22 13:11:03, Erik Dahlström wrote: > The SVG WG resolved at TPAC 2013 to ...
7 years, 1 month ago (2013-11-23 02:18:30 UTC) #5
Erik Dahlström (inactive)
https://codereview.chromium.org/45733010/diff/1/LayoutTests/svg/hittest/svg-pointer-events-bbox.txt File LayoutTests/svg/hittest/svg-pointer-events-bbox.txt (right): https://codereview.chromium.org/45733010/diff/1/LayoutTests/svg/hittest/svg-pointer-events-bbox.txt#newcode1 LayoutTests/svg/hittest/svg-pointer-events-bbox.txt:1: Tests for pointer-events=boundingBox - hit testing. On 2013/11/01 03:42:00, ...
7 years ago (2013-11-29 16:30:48 UTC) #6
pdr.
I apologize for the slow response (Thanksgiving holiday in the US). This now looks good ...
7 years ago (2013-12-02 02:57:25 UTC) #7
Erik Dahlström (inactive)
On 2013/12/02 02:57:25, pdr wrote: > I apologize for the slow response (Thanksgiving holiday in ...
7 years ago (2013-12-02 09:49:21 UTC) #8
krit
On 2013/12/02 09:49:21, Erik Dahlström wrote: > On 2013/12/02 02:57:25, pdr wrote: > > I ...
7 years ago (2013-12-02 10:19:00 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ed@opera.com/45733010/170001
7 years ago (2013-12-02 16:12:00 UTC) #10
commit-bot: I haz the power
Failed to apply patch for Source/core/rendering/svg/RenderSVGShape.cpp: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years ago (2013-12-02 16:12:12 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ed@opera.com/45733010/190001
7 years ago (2013-12-03 12:47:10 UTC) #12
commit-bot: I haz the power
Retried try job too often on blink_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_presubmit&number=12201
7 years ago (2013-12-03 13:03:20 UTC) #13
pdr.
On 2013/12/03 13:03:20, I haz the power (commit-bot) wrote: > Retried try job too often ...
7 years ago (2013-12-03 17:22:00 UTC) #14
abarth-chromium
On 2013/12/03 17:22:00, pdr wrote: > On 2013/12/03 13:03:20, I haz the power (commit-bot) wrote: ...
7 years ago (2013-12-03 18:36:45 UTC) #15
pdr.
On 2013/12/03 18:36:45, abarth wrote: > On 2013/12/03 17:22:00, pdr wrote: > > On 2013/12/03 ...
7 years ago (2013-12-03 18:43:15 UTC) #16
aandrey
lgtm
7 years ago (2013-12-03 19:38:49 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ed@opera.com/45733010/190001
7 years ago (2013-12-04 08:32:33 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ed@opera.com/45733010/190001
7 years ago (2013-12-05 09:37:42 UTC) #19
commit-bot: I haz the power
Retried try job too often on linux_blink for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink&number=4719
7 years ago (2013-12-05 13:05:57 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ed@opera.com/45733010/190001
7 years ago (2013-12-05 23:11:37 UTC) #21
commit-bot: I haz the power
Retried try job too often on linux_blink for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink&number=4777
7 years ago (2013-12-06 12:53:27 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ed@opera.com/45733010/210001
7 years ago (2013-12-09 10:30:41 UTC) #23
commit-bot: I haz the power
7 years ago (2013-12-09 11:37:19 UTC) #24
Message was sent while issue was closed. 
Change committed as 163425

Powered by Google App Engine
This is Rietveld 408576698