Source/core/rendering/svg/SVGInlineTextBox.cpp - Issue 45733010: Add pointer-events="bounding-box" for svg content.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/svg/SVGInlineTextBox.cpp

Issue 45733010: Add pointer-events="bounding-box" for svg content. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: make assert more specific Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/rendering/svg/SVGInlineTextBox.cpp

diff --git a/Source/core/rendering/svg/SVGInlineTextBox.cpp b/Source/core/rendering/svg/SVGInlineTextBox.cpp

index f2afa1e653e223a1d4b6de47c9f3ef96c5880919..5608f9919c082317fef68160a9f8f82d978efb77 100644

--- a/Source/core/rendering/svg/SVGInlineTextBox.cpp

+++ b/Source/core/rendering/svg/SVGInlineTextBox.cpp

@@ -738,7 +738,8 @@ bool SVGInlineTextBox::nodeAtPoint(const HitTestRequest& request, HitTestResult&

PointerEventsHitRules hitRules(PointerEventsHitRules::SVG_TEXT_HITTESTING, request, renderer()->style()->pointerEvents());

bool isVisible = renderer()->style()->visibility() == VISIBLE;

if (isVisible || !hitRules.requireVisible) {

- if ((hitRules.canHitStroke && (renderer()->style()->svgStyle()->hasStroke() || !hitRules.requireStroke))

+ if (hitRules.canHitBoundingBox

+ || (hitRules.canHitStroke && (renderer()->style()->svgStyle()->hasStroke() || !hitRules.requireStroke))

|| (hitRules.canHitFill && (renderer()->style()->svgStyle()->hasFill() || !hitRules.requireFill))) {

FloatPoint boxOrigin(x(), y());

boxOrigin.moveBy(accumulatedOffset);