Issue 45733007: Do not dispatch events in Document::nodeChildrenWillBeRemoved().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 45733007: Do not dispatch events in Document::nodeChildrenWillBeRemoved(). (Closed)

Created:
7 years, 1 month ago by tkent

Modified:
7 years, 1 month ago

Reviewers:
Hajime Morrita

CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, adamk+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Do not dispatch events in Document::nodeChildrenWillBeRemoved(). FrameSelection::nodeWillBeRemoved() can dispatch 'beforeload' events for plugin elements. Avoid it by wrapping Document:: nodeChildrenWillBeRemoved() call with RenderWidget::UpdateSuspendScope. BUG=312639 TEST=automated R=morrita@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160918

Patch Set 1 : #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -3 lines)			Patch
M	LayoutTests/TestExpectations	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	Source/core/dom/ContainerNode.cpp	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	Source/core/dom/Document.cpp	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/45733007/80001

7 years, 1 month ago (2013-10-30 08:50:38 UTC) #3

Message was sent while issue was closed.

Change committed as 160918

Expand Messages | Collapse Messages