Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Side by Side Diff: Source/core/dom/Document.cpp

Issue 45733007: Do not dispatch events in Document::nodeChildrenWillBeRemoved(). (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/dom/ContainerNode.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * (C) 2006 Alexey Proskuryakov (ap@webkit.org) 5 * (C) 2006 Alexey Proskuryakov (ap@webkit.org)
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011, 2012 Apple Inc. All r ights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011, 2012 Apple Inc. All r ights reserved.
7 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/) 7 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/)
8 * Copyright (C) 2008, 2009, 2011, 2012 Google Inc. All rights reserved. 8 * Copyright (C) 2008, 2009, 2011, 2012 Google Inc. All rights reserved.
9 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies) 9 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
10 * Copyright (C) Research In Motion Limited 2010-2011. All rights reserved. 10 * Copyright (C) Research In Motion Limited 2010-2011. All rights reserved.
(...skipping 3481 matching lines...) Expand 10 before | Expand all | Expand 10 after
3492 { 3492 {
3493 if (!m_ranges.isEmpty()) { 3493 if (!m_ranges.isEmpty()) {
3494 HashSet<Range*>::const_iterator end = m_ranges.end(); 3494 HashSet<Range*>::const_iterator end = m_ranges.end();
3495 for (HashSet<Range*>::const_iterator it = m_ranges.begin(); it != end; + +it) 3495 for (HashSet<Range*>::const_iterator it = m_ranges.begin(); it != end; + +it)
3496 (*it)->nodeChildrenChanged(container); 3496 (*it)->nodeChildrenChanged(container);
3497 } 3497 }
3498 } 3498 }
3499 3499
3500 void Document::nodeChildrenWillBeRemoved(ContainerNode* container) 3500 void Document::nodeChildrenWillBeRemoved(ContainerNode* container)
3501 { 3501 {
3502 NoEventDispatchAssertion assertNoEventDispatch;
3502 if (!m_ranges.isEmpty()) { 3503 if (!m_ranges.isEmpty()) {
3503 HashSet<Range*>::const_iterator end = m_ranges.end(); 3504 HashSet<Range*>::const_iterator end = m_ranges.end();
3504 for (HashSet<Range*>::const_iterator it = m_ranges.begin(); it != end; + +it) 3505 for (HashSet<Range*>::const_iterator it = m_ranges.begin(); it != end; + +it)
3505 (*it)->nodeChildrenWillBeRemoved(container); 3506 (*it)->nodeChildrenWillBeRemoved(container);
3506 } 3507 }
3507 3508
3508 HashSet<NodeIterator*>::const_iterator nodeIteratorsEnd = m_nodeIterators.en d(); 3509 HashSet<NodeIterator*>::const_iterator nodeIteratorsEnd = m_nodeIterators.en d();
3509 for (HashSet<NodeIterator*>::const_iterator it = m_nodeIterators.begin(); it != nodeIteratorsEnd; ++it) { 3510 for (HashSet<NodeIterator*>::const_iterator it = m_nodeIterators.begin(); it != nodeIteratorsEnd; ++it) {
3510 for (Node* n = container->firstChild(); n; n = n->nextSibling()) 3511 for (Node* n = container->firstChild(); n; n = n->nextSibling())
3511 (*it)->nodeWillBeRemoved(n); 3512 (*it)->nodeWillBeRemoved(n);
(...skipping 1766 matching lines...) Expand 10 before | Expand all | Expand 10 after
5278 void Document::modifiedStyleSheet(StyleSheet* sheet, RecalcStyleTime when, Style ResolverUpdateMode updateMode) 5279 void Document::modifiedStyleSheet(StyleSheet* sheet, RecalcStyleTime when, Style ResolverUpdateMode updateMode)
5279 { 5280 {
5280 if (!isActive()) 5281 if (!isActive())
5281 return; 5282 return;
5282 5283
5283 styleEngine()->modifiedStyleSheet(sheet); 5284 styleEngine()->modifiedStyleSheet(sheet);
5284 styleResolverChanged(when, updateMode); 5285 styleResolverChanged(when, updateMode);
5285 } 5286 }
5286 5287
5287 } // namespace WebCore 5288 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/core/dom/ContainerNode.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698