Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 456873003: Add BlitRect to SkTCompressedAlphaBlitter (Closed)

Created:
6 years, 4 months ago by krajcevski
Modified:
6 years, 4 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Add BlitRect to SkTCompressedAlphaBlitter Committed: https://skia.googlesource.com/skia/+/a10555a354cf294bde217044472d33c3161df249

Patch Set 1 #

Patch Set 2 : Reset GrSWMaskHelper #

Patch Set 3 : Remove excess #

Patch Set 4 : Small cleanup #

Total comments: 2

Patch Set 5 : Small nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+339 lines, -40 lines) Patch
M src/utils/SkTextureCompressor_ASTC.cpp View 2 chunks +18 lines, -1 line 0 comments Download
M src/utils/SkTextureCompressor_Blitter.h View 1 2 3 4 8 chunks +260 lines, -21 lines 0 comments Download
M src/utils/SkTextureCompressor_LATC.cpp View 1 2 3 3 chunks +53 lines, -17 lines 0 comments Download
M src/utils/SkTextureCompressor_R11EAC.cpp View 1 chunk +8 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
krajcevski
6 years, 4 months ago (2014-08-11 18:41:17 UTC) #1
robertphillips
lgtm + nit https://codereview.chromium.org/456873003/diff/60001/src/utils/SkTextureCompressor_Blitter.h File src/utils/SkTextureCompressor_Blitter.h (right): https://codereview.chromium.org/456873003/diff/60001/src/utils/SkTextureCompressor_Blitter.h#newcode66 src/utils/SkTextureCompressor_Blitter.h:66: #ifdef SK_DEBUG Mv this ',' down ...
6 years, 4 months ago (2014-08-11 19:16:22 UTC) #2
krajcevski
The CQ bit was checked by krajcevski@google.com
6 years, 4 months ago (2014-08-11 20:06:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/krajcevski@google.com/456873003/80001
6 years, 4 months ago (2014-08-11 20:06:33 UTC) #4
krajcevski
https://codereview.chromium.org/456873003/diff/60001/src/utils/SkTextureCompressor_Blitter.h File src/utils/SkTextureCompressor_Blitter.h (right): https://codereview.chromium.org/456873003/diff/60001/src/utils/SkTextureCompressor_Blitter.h#newcode66 src/utils/SkTextureCompressor_Blitter.h:66: #ifdef SK_DEBUG On 2014/08/11 19:16:22, robertphillips wrote: > Mv ...
6 years, 4 months ago (2014-08-11 20:08:24 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-11 20:34:30 UTC) #6
Message was sent while issue was closed. 
Change committed as a10555a354cf294bde217044472d33c3161df249

Powered by Google App Engine
This is Rietveld 408576698