Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Unified Diff: chrome/browser/autocomplete/base_search_provider.h

Issue 456843003: Remove protected virtual methods from BaseSearchProvider (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Revert getters Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/autocomplete/base_search_provider.h
diff --git a/chrome/browser/autocomplete/base_search_provider.h b/chrome/browser/autocomplete/base_search_provider.h
index 0f3b05cc8bcee79af17d326a4cede724ecdf68ff..29797967eb611b89d770ee34dd9ed83a1587d686 100644
--- a/chrome/browser/autocomplete/base_search_provider.h
+++ b/chrome/browser/autocomplete/base_search_provider.h
@@ -68,7 +68,6 @@ class BaseSearchProvider : public AutocompleteProvider {
const SearchTermsData& search_terms_data);
// AutocompleteProvider:
- virtual void Stop(bool clear_cached_results) OVERRIDE;
virtual void DeleteMatch(const AutocompleteMatch& match) OVERRIDE;
virtual void AddProviderInfo(ProvidersInfo* provider_info) const OVERRIDE;
@@ -211,20 +210,9 @@ class BaseSearchProvider : public AutocompleteProvider {
virtual bool ShouldAppendExtraParams(
const SearchSuggestionParser::SuggestResult& result) const = 0;
- // Stops the suggest query.
- // NOTE: This does not update |done_|. Callers must do so.
- virtual void StopSuggest() = 0;
-
- // Clears the current results.
- virtual void ClearAllResults() = 0;
-
// Records in UMA whether the deletion request resulted in success.
virtual void RecordDeletionResult(bool success) = 0;
- // Modify provider-specific UMA statistics.
- virtual void ModifyProviderInfo(
- metrics::OmniboxEventProto_ProviderInfo* provider_info) const;
-
TemplateURLService* template_url_service_;
Profile* profile_;
« no previous file with comments | « no previous file | chrome/browser/autocomplete/base_search_provider.cc » ('j') | chrome/browser/autocomplete/search_provider.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698