Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1516)

Unified Diff: chrome/browser/autocomplete/base_search_provider.cc

Issue 456843003: Remove protected virtual methods from BaseSearchProvider (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Revert getters Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/autocomplete/base_search_provider.cc
diff --git a/chrome/browser/autocomplete/base_search_provider.cc b/chrome/browser/autocomplete/base_search_provider.cc
index 29a6ac0c7225ee38eb04a4322b8c999aae250402..cf76a58e5846317ddcf884906c709055afc541ce 100644
--- a/chrome/browser/autocomplete/base_search_provider.cc
+++ b/chrome/browser/autocomplete/base_search_provider.cc
@@ -124,14 +124,6 @@ AutocompleteMatch BaseSearchProvider::CreateSearchSuggestion(
template_url, search_terms_data, 0, false);
}
-void BaseSearchProvider::Stop(bool clear_cached_results) {
- StopSuggest();
- done_ = true;
-
- if (clear_cached_results)
- ClearAllResults();
-}
-
void BaseSearchProvider::DeleteMatch(const AutocompleteMatch& match) {
DCHECK(match.deletable);
if (!match.GetAdditionalInfo(BaseSearchProvider::kDeletionUrlKey).empty()) {
@@ -173,7 +165,6 @@ void BaseSearchProvider::AddProviderInfo(ProvidersInfo* provider_info) const {
field_trial_hashes[i]);
}
}
- ModifyProviderInfo(&new_entry);
}
// static
@@ -467,10 +458,6 @@ bool BaseSearchProvider::ParseSuggestResults(
return true;
}
-void BaseSearchProvider::ModifyProviderInfo(
- metrics::OmniboxEventProto_ProviderInfo* provider_info) const {
-}
-
void BaseSearchProvider::DeleteMatchFromMatches(
const AutocompleteMatch& match) {
for (ACMatches::iterator i(matches_.begin()); i != matches_.end(); ++i) {

Powered by Google App Engine
This is Rietveld 408576698