short circuit high quality scales that are actually the identity

short circuit high quality scales that are actually the identity
transform

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/8d9153fca25897bf40ca0ebac8b03616612cc7b4

[humper, 2014-08-08 17:17:59]

ptal; I've manually tried this in Chrome and it seemed to be working.

[humper, 2014-08-08 17:27:07]

The CQ bit was checked by humper@google.com

[commit-bot: I haz the power, 2014-08-08 17:27:50]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/humper@google.com/456843002/1

[commit-bot: I haz the power, 2014-08-08 17:27:51]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from a valid reviewer till 2014-08-08 23:27 UTC

[reed1, 2014-08-08 17:33:55]

lets modify the comment to justify the exit as a perf win (since HQ doesn't add
any value when there is no scale.

Can we use SkScalarNearlyEqual(scale, 1) instead of scale == 1 ?

[humper, 2014-08-08 18:07:56]

On 2014/08/08 17:33:55, reed1 wrote:
> lets modify the comment to justify the exit as a perf win (since HQ doesn't
add
> any value when there is no scale.
> 
> Can we use SkScalarNearlyEqual(scale, 1) instead of scale == 1 ?

Changed the comments, nearly equal, and changed the termination condition to use
low quality instead of none as per our discussion.

[reed1, 2014-08-08 18:28:21]

seems like we can also abort on nearly -1 ... maybe just a comment to that
effect.

https://codereview.chromium.org/456843002/diff/40001/src/core/SkBitmapProcSta...
File src/core/SkBitmapProcState.cpp (right):

https://codereview.chromium.org/456843002/diff/40001/src/core/SkBitmapProcSta...
src/core/SkBitmapProcState.cpp:175: // TODO -- consider short circuiting here if
the scale is
remove the TODO

https://codereview.chromium.org/456843002/diff/40001/src/core/SkBitmapProcSta...
src/core/SkBitmapProcState.cpp:478: //
remove //

https://codereview.chromium.org/456843002/diff/40001/src/core/SkBitmapProcSta...
src/core/SkBitmapProcState.cpp:480: if (trivialMatrix && fFilterLevel >
SkPaint::kMedium_FilterLevel) {
I *think* we can remove this check now, yes?

[humper, 2014-08-08 18:37:47]

The CQ bit was checked by humper@google.com

[commit-bot: I haz the power, 2014-08-08 18:38:36]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/humper@google.com/456843002/40001

[commit-bot: I haz the power, 2014-08-08 18:38:37]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from a valid reviewer till 2014-08-09 00:38 UTC

[humper, 2014-08-08 18:39:05]

https://codereview.chromium.org/456843002/diff/40001/src/core/SkBitmapProcSta...
File src/core/SkBitmapProcState.cpp (right):

https://codereview.chromium.org/456843002/diff/40001/src/core/SkBitmapProcSta...
src/core/SkBitmapProcState.cpp:175: // TODO -- consider short circuiting here if
the scale is
On 2014/08/08 18:28:21, reed1 wrote:
> remove the TODO

Done.

https://codereview.chromium.org/456843002/diff/40001/src/core/SkBitmapProcSta...
src/core/SkBitmapProcState.cpp:480: if (trivialMatrix && fFilterLevel >
SkPaint::kMedium_FilterLevel) {
On 2014/08/08 18:28:21, reed1 wrote:
> I *think* we can remove this check now, yes?

Done.

[humper, 2014-08-08 18:42:50]

The CQ bit was checked by humper@google.com

[commit-bot: I haz the power, 2014-08-08 18:43:28]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/humper@google.com/456843002/60001

[commit-bot: I haz the power, 2014-08-08 18:43:29]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from a valid reviewer till 2014-08-09 00:43 UTC

[humper, 2014-08-08 18:57:08]

The CQ bit was checked by humper@google.com

[commit-bot: I haz the power, 2014-08-08 18:57:15]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/humper@google.com/456843002/80001

[commit-bot: I haz the power, 2014-08-08 18:57:16]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from a valid reviewer till 2014-08-09 00:57 UTC

[reed1, 2014-08-08 19:05:08]

lgtm

[commit-bot: I haz the power, 2014-08-08 19:06:19]

Change committed as 8d9153fca25897bf40ca0ebac8b03616612cc7b4