Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Unified Diff: Source/bindings/tests/results/V8TestInterface3.cpp

Issue 456683002: bindings: Introduces type-check for the internal pointers. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Finally fixed hidden misconversions to internal pointers. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/tests/results/V8TestInterface3.cpp
diff --git a/Source/bindings/tests/results/V8TestInterface3.cpp b/Source/bindings/tests/results/V8TestInterface3.cpp
index d42bbba2d31b1e5d8b09033d13b63340ecbd0e69..270c9ea87f266b637f08ae3576446c6640506999 100644
--- a/Source/bindings/tests/results/V8TestInterface3.cpp
+++ b/Source/bindings/tests/results/V8TestInterface3.cpp
@@ -137,7 +137,7 @@ v8::Handle<v8::Object> V8TestInterface3::findInstanceInPrototypeChain(v8::Handle
TestInterface3* V8TestInterface3::toNativeWithTypeCheck(v8::Isolate* isolate, v8::Handle<v8::Value> value)
{
- return hasInstance(value, isolate) ? fromInternalPointer(v8::Handle<v8::Object>::Cast(value)->GetAlignedPointerFromInternalField(v8DOMWrapperObjectIndex)) : 0;
+ return hasInstance(value, isolate) ? fromInternalPointer(blink::toInternalPointer(v8::Handle<v8::Object>::Cast(value))) : 0;
}
v8::Handle<v8::Object> wrap(TestInterface3* impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate)
@@ -167,9 +167,9 @@ v8::Handle<v8::Object> V8TestInterface3::createWrapper(PassRefPtr<TestInterface3
return wrapper;
}
-void V8TestInterface3::derefObject(void* object)
+void V8TestInterface3::derefObject(ScriptWrappableBase* internalPointer)
{
- fromInternalPointer(object)->deref();
+ fromInternalPointer(internalPointer)->deref();
}
template<>

Powered by Google App Engine
This is Rietveld 408576698