bindings: Introduces type-check for the internal pointers.

Source/bindings/templates/interface.cpp

Index: Source/bindings/templates/interface.cpp
diff --git a/Source/bindings/templates/interface.cpp b/Source/bindings/templates/interface.cpp
index cfc45dc516a45c2605b35745832d46909c4b89d9..8de72fe44c9067a456041aa5190eaf4cb4b2d59a 100644
--- a/Source/bindings/templates/interface.cpp
+++ b/Source/bindings/templates/interface.cpp
@@ -696,9 +696,9 @@ static void constructor(const v8::FunctionCallbackInfo<v8::Value>& info)
 {##############################################################################}
 {% block visit_dom_wrapper %}
 {% if reachable_node_function or set_wrapper_reference_to_list %}
-void {{v8_class}}::visitDOMWrapper(void* object, const v8::Persistent<v8::Object>& wrapper, v8::Isolate* isolate)
+void {{v8_class}}::visitDOMWrapper(ScriptWrappableBase* internalPointer, const v8::Persistent<v8::Object>& wrapper, v8::Isolate* isolate)
 {
-    {{cpp_class}}* impl = fromInternalPointer(object);
+    {{cpp_class}}* impl = fromInternalPointer(internalPointer);
     {% if set_wrapper_reference_to_list %}
     v8::Local<v8::Object> creationContext = v8::Local<v8::Object>::New(isolate, wrapper);
     V8WrapperInstantiationScope scope(creationContext, isolate);
@@ -719,7 +719,7 @@ void {{v8_class}}::visitDOMWrapper(void* object, const v8::Persistent<v8::Object
         return;
     }
     {% endif %}
-    setObjectGroup(object, wrapper, isolate);
+    setObjectGroup(internalPointer, wrapper, isolate);
 }
 
 {% endif %}
@@ -1148,7 +1148,7 @@ v8::Handle<v8::Object> {{v8_class}}::findInstanceInPrototypeChain(v8::Handle<v8:
 {% block to_native_with_type_check %}
 {{cpp_class}}* {{v8_class}}::toNativeWithTypeCheck(v8::Isolate* isolate, v8::Handle<v8::Value> value)
 {
-    return hasInstance(value, isolate) ? fromInternalPointer(v8::Handle<v8::Object>::Cast(value)->GetAlignedPointerFromInternalField(v8DOMWrapperObjectIndex)) : 0;
+    return hasInstance(value, isolate) ? fromInternalPointer(blink::toInternalPointer(v8::Handle<v8::Object>::Cast(value))) : 0;

[haraken, 2014/08/08 15:50:31]

fromInternalPointer(toInternalPointer(value)) is a bit confusing.

Probably we can:

- Rename toInternalPointer to toScriptWrappableBase
- Rename fromInternalPointer to toImpl
- Remove toNative
- Rename toNativeWithTypeCheck to toImplWithTypeCheck

You can do the refactoring in a separate CL.

[Yuki, 2014/08/11 05:42:00]

I see.  Let's choose the best name with an offline discussion, and then, I'll
rename it.

 }
 
 {% endblock %}
@@ -1335,13 +1335,13 @@ v8::Handle<v8::Object> {{v8_class}}::createWrapper({{pass_cpp_type}} impl, v8::H
 
 {##############################################################################}
 {% block deref_object_and_to_v8_no_inline %}
-void {{v8_class}}::derefObject(void* object)
+void {{v8_class}}::derefObject(ScriptWrappableBase* internalPointer)
 {
 {% if gc_type == 'RefCountedObject' %}
-    fromInternalPointer(object)->deref();
+    fromInternalPointer(internalPointer)->deref();
 {% elif gc_type == 'WillBeGarbageCollectedObject' %}
 {% filter conditional('!ENABLE(OILPAN)') %}
-    fromInternalPointer(object)->deref();
+    fromInternalPointer(internalPointer)->deref();
 {% endfilter %}
 {% endif %}
 }