Source/bindings/core/v8/custom/V8InjectedScriptManager.cpp - Issue 456683002: bindings: Introduces type-check for the internal pointers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/core/v8/custom/V8InjectedScriptManager.cpp

Issue 456683002: bindings: Introduces type-check for the internal pointers. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Finally fixed hidden misconversions to internal pointers. Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/bindings/core/v8/CustomElementWrapper.cpp ('K') | « Source/bindings/core/v8/custom/V8ArrayBufferCustom.cpp ('k') | Source/bindings/core/v8/custom/V8MutationObserverCustom.cpp » ('j') | Source/bindings/templates/interface.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/core/v8/custom/V8InjectedScriptManager.cpp

diff --git a/Source/bindings/core/v8/custom/V8InjectedScriptManager.cpp b/Source/bindings/core/v8/custom/V8InjectedScriptManager.cpp

index 12577dc41c98754c67f10ab118e6293d94f21a1c..1860116c73243dcc06dbac591fd69c6d8d651a03 100644

--- a/Source/bindings/core/v8/custom/V8InjectedScriptManager.cpp

+++ b/Source/bindings/core/v8/custom/V8InjectedScriptManager.cpp

@@ -64,9 +64,9 @@ static v8::Local<v8::Object> createInjectedScriptHostV8Wrapper(InjectedScriptHos

return v8::Local<v8::Object>();

}

#if ENABLE(OILPAN)

- V8DOMWrapper::setNativeInfoWithPersistentHandle(instanceTemplate, &V8InjectedScriptHost::wrapperTypeInfo, host, new Persistent<InjectedScriptHost>(host));

+ V8DOMWrapper::setNativeInfoWithPersistentHandle(instanceTemplate, &V8InjectedScriptHost::wrapperTypeInfo, V8InjectedScriptHost::toInternalPointer(host), new Persistent<InjectedScriptHost>(host));

#else

- V8DOMWrapper::setNativeInfo(instanceTemplate, &V8InjectedScriptHost::wrapperTypeInfo, host);

+ V8DOMWrapper::setNativeInfo(instanceTemplate, &V8InjectedScriptHost::wrapperTypeInfo, V8InjectedScriptHost::toInternalPointer(host));

#endif

// Create a weak reference to the v8 wrapper of InspectorBackend to deref

// InspectorBackend when the wrapper is garbage collected.