Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Unified Diff: Source/bindings/core/v8/CustomElementWrapper.cpp

Issue 456683002: bindings: Introduces type-check for the internal pointers. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Finally fixed hidden misconversions to internal pointers. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/bindings/core/v8/DOMWrapperMap.h » ('j') | Source/bindings/templates/interface.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/core/v8/CustomElementWrapper.cpp
diff --git a/Source/bindings/core/v8/CustomElementWrapper.cpp b/Source/bindings/core/v8/CustomElementWrapper.cpp
index eaeb802e9836b9954b4cf5f18f60d32f59da91c2..1bc2625d9dd0ca917775452b4e6ad5d340ea1518 100644
--- a/Source/bindings/core/v8/CustomElementWrapper.cpp
+++ b/Source/bindings/core/v8/CustomElementWrapper.cpp
@@ -101,7 +101,7 @@ v8::Handle<v8::Object> CustomElementWrapper<ElementType, WrapperType>::wrap(Pass
return v8::Handle<v8::Object>();
CustomElementBinding* binding = perContextData->customElementBinding(element->customElementDefinition());
- v8::Handle<v8::Object> wrapper = V8DOMWrapper::createWrapper(creationContext, binding->wrapperType(), element.get(), isolate);
+ v8::Handle<v8::Object> wrapper = V8DOMWrapper::createWrapper(creationContext, binding->wrapperType(), WrapperType::toInternalPointer(element.get()), isolate);
haraken 2014/08/08 15:50:31 What happens if someone passes element.get() to cr
Yuki 2014/08/11 05:42:00 Your idea sounds very nice and I'll add that check
if (wrapper.IsEmpty())
return v8::Handle<v8::Object>();
« no previous file with comments | « no previous file | Source/bindings/core/v8/DOMWrapperMap.h » ('j') | Source/bindings/templates/interface.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698