Source/bindings/tests/results/V8TestInterfaceWillBeGarbageCollected.cpp - Issue 456683002: bindings: Introduces type-check for the internal pointers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/tests/results/V8TestInterfaceWillBeGarbageCollected.cpp

Issue 456683002: bindings: Introduces type-check for the internal pointers. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Synced. Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/bindings/tests/results/V8TestInterfaceWillBeGarbageCollected.h ('k') | Source/bindings/tests/results/V8TestNode.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/tests/results/V8TestInterfaceWillBeGarbageCollected.cpp

diff --git a/Source/bindings/tests/results/V8TestInterfaceWillBeGarbageCollected.cpp b/Source/bindings/tests/results/V8TestInterfaceWillBeGarbageCollected.cpp

index e32b1ed32eee10ee978900f35a8e95665030012e..5f6d1581ca8003723e80ba23c3942cc85174429c 100644

--- a/Source/bindings/tests/results/V8TestInterfaceWillBeGarbageCollected.cpp

+++ b/Source/bindings/tests/results/V8TestInterfaceWillBeGarbageCollected.cpp

@@ -219,7 +219,7 @@ v8::Handle<v8::Object> V8TestInterfaceWillBeGarbageCollected::findInstanceInProt

TestInterfaceWillBeGarbageCollected* V8TestInterfaceWillBeGarbageCollected::toNativeWithTypeCheck(v8::Isolate* isolate, v8::Handle<v8::Value> value)

{

- return hasInstance(value, isolate) ? fromInternalPointer(v8::Handle<v8::Object>::Cast(value)->GetAlignedPointerFromInternalField(v8DOMWrapperObjectIndex)) : 0;

+ return hasInstance(value, isolate) ? fromInternalPointer(blink::toInternalPointer(v8::Handle<v8::Object>::Cast(value))) : 0;

}

EventTarget* V8TestInterfaceWillBeGarbageCollected::toEventTarget(v8::Handle<v8::Object> object)

@@ -254,10 +254,10 @@ v8::Handle<v8::Object> V8TestInterfaceWillBeGarbageCollected::createWrapper(Pass

return wrapper;

}

-void V8TestInterfaceWillBeGarbageCollected::derefObject(void* object)

+void V8TestInterfaceWillBeGarbageCollected::derefObject(ScriptWrappableBase* internalPointer)

{

#if !ENABLE(OILPAN)

- fromInternalPointer(object)->deref();

+ fromInternalPointer(internalPointer)->deref();

#endif // !ENABLE(OILPAN)

}