Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Unified Diff: Source/bindings/tests/results/V8TestInterfaceWillBeGarbageCollected.h

Issue 456683002: bindings: Introduces type-check for the internal pointers. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Synced. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/tests/results/V8TestInterfaceWillBeGarbageCollected.h
diff --git a/Source/bindings/tests/results/V8TestInterfaceWillBeGarbageCollected.h b/Source/bindings/tests/results/V8TestInterfaceWillBeGarbageCollected.h
index d5a0c104355091dfd602f90b2f6c67b360dfacab..9a50eed3ce7db63dc74abb2c93c985f941133359 100644
--- a/Source/bindings/tests/results/V8TestInterfaceWillBeGarbageCollected.h
+++ b/Source/bindings/tests/results/V8TestInterfaceWillBeGarbageCollected.h
@@ -7,6 +7,7 @@
#ifndef V8TestInterfaceWillBeGarbageCollected_h
#define V8TestInterfaceWillBeGarbageCollected_h
+#include "bindings/core/v8/ScriptWrappable.h"
#include "bindings/core/v8/V8Binding.h"
#include "bindings/core/v8/V8DOMWrapper.h"
#include "bindings/core/v8/WrapperTypeInfo.h"
@@ -29,11 +30,11 @@ public:
static v8::Handle<v8::FunctionTemplate> domTemplate(v8::Isolate*);
static TestInterfaceWillBeGarbageCollected* toNative(v8::Handle<v8::Object> object)
{
- return fromInternalPointer(object->GetAlignedPointerFromInternalField(v8DOMWrapperObjectIndex));
+ return fromInternalPointer(blink::toInternalPointer(object));
}
static TestInterfaceWillBeGarbageCollected* toNativeWithTypeCheck(v8::Isolate*, v8::Handle<v8::Value>);
static const WrapperTypeInfo wrapperTypeInfo;
- static void derefObject(void*);
+ static void derefObject(ScriptWrappableBase* internalPointer);
static EventTarget* toEventTarget(v8::Handle<v8::Object>);
static void constructorCallback(const v8::FunctionCallbackInfo<v8::Value>&);
static const int eventListenerCacheIndex = v8DefaultWrapperInternalFieldCount + 0;
@@ -43,14 +44,14 @@ public:
#else
static const int internalFieldCount = v8DefaultWrapperInternalFieldCount + 1;
#endif
- static inline void* toInternalPointer(TestInterfaceWillBeGarbageCollected* impl)
+ static inline ScriptWrappableBase* toInternalPointer(TestInterfaceWillBeGarbageCollected* impl)
{
return V8EventTarget::toInternalPointer(impl);
}
- static inline TestInterfaceWillBeGarbageCollected* fromInternalPointer(void* object)
+ static inline TestInterfaceWillBeGarbageCollected* fromInternalPointer(ScriptWrappableBase* internalPointer)
{
- return static_cast<TestInterfaceWillBeGarbageCollected*>(V8EventTarget::fromInternalPointer(object));
+ return static_cast<TestInterfaceWillBeGarbageCollected*>(V8EventTarget::fromInternalPointer(internalPointer));
}
static void installPerContextEnabledProperties(v8::Handle<v8::Object>, TestInterfaceWillBeGarbageCollected*, v8::Isolate*) { }
static void installPerContextEnabledMethods(v8::Handle<v8::Object>, v8::Isolate*) { }

Powered by Google App Engine
This is Rietveld 408576698