Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 456513002: Add base:: qualification to some CommandLine references in content. (Closed)

Created:
6 years, 4 months ago by brettw
Modified:
6 years, 4 months ago
Reviewers:
sky
CC:
chromium-reviews, asanka, yusukes+watch_chromium.org, tzik, posciak+watch_chromium.org, nasko+codewatch_chromium.org, sievers+watch_chromium.org, yukishiino+watch_chromium.org, dmazzoni+watch_chromium.org, ajwong+watch_chromium.org, jdduke+watch_chromium.org, miu+watch_chromium.org, jsbell+serviceworker_chromium.org, cbentzel+watch_chromium.org, aboxhall+watch_chromium.org, jam, jbauman+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, kalyank, creis+watch_chromium.org, penghuang+watch_chromium.org, yuzo+watch_chromium.org, feature-media-reviews_chromium.org, dsinclair+watch_chromium.org, nhiroki, piman+watch_chromium.org, alecflett+watch_chromium.org, michaeln, plundblad+watch_chromium.org, wfh+watch_chromium.org, serviceworker-reviews, mcasas+watch_chromium.org, benjhayden+dwatch_chromium.org, kinuko+serviceworker, dtseng+watch_chromium.org, horo+watch_chromium.org, danakj+watch_chromium.org, James Su, wjia+watch_chromium.org, jln+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Add base:: qualification to some COmmandLine references in content. TBR=sky Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288787

Patch Set 1 #

Patch Set 2 : imerge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+335 lines, -253 lines) Patch
M content/app/android/library_loader_hooks.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/app/content_main_runner.cc View 10 chunks +15 lines, -11 lines 0 comments Download
M content/app/startup_helper_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/accessibility/browser_accessibility_state_impl.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M content/browser/accessibility/dump_accessibility_tree_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/android/child_process_launcher_android.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M content/browser/android/content_startup_flags.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/android/content_video_view.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/appcache/appcache_database.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M content/browser/appcache/manifest_parser.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/browser_child_process_host_impl.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M content/browser/browser_main_loop.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M content/browser/browser_main_runner.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/browser_shutdown_profile_dumper.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/child_process_launcher.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M content/browser/child_process_security_policy_impl.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M content/browser/compositor/delegated_frame_host.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/compositor/gpu_process_transport_factory.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M content/browser/compositor/image_transport_factory.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/download/download_browsertest.cc View 12 chunks +12 lines, -12 lines 0 comments Download
M content/browser/download/download_item_impl.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M content/browser/download/download_item_impl_unittest.cc View 8 chunks +8 lines, -8 lines 0 comments Download
M content/browser/frame_host/debug_urls.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M content/browser/frame_host/navigation_entry_screenshot_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/frame_host/navigator_impl.cc View 3 chunks +6 lines, -4 lines 0 comments Download
M content/browser/gpu/compositor_util.cc View 6 chunks +12 lines, -6 lines 0 comments Download
M content/browser/gpu/gpu_data_manager_impl_private.cc View 12 chunks +18 lines, -14 lines 0 comments Download
M content/browser/gpu/gpu_data_manager_impl_private_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/gpu/gpu_internals_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/gpu/gpu_process_host.cc View 9 chunks +17 lines, -12 lines 0 comments Download
M content/browser/histogram_message_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/loader/async_resource_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/loader/cross_site_resource_handler.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/loader/resource_dispatcher_host_impl.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M content/browser/mach_broker_mac.mm View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/media/webrtc_browsertest.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/net/sqlite_persistent_cookie_store.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/plugin_process_host.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M content/browser/plugin_service_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/power_save_blocker_x11.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/ppapi_plugin_process_host.cc View 3 chunks +7 lines, -5 lines 0 comments Download
M content/browser/renderer_host/compositor_impl_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/input/input_router_config_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/input/input_router_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/media/audio_renderer_host_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/media/media_stream_dispatcher_host_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/media/media_stream_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/overscroll_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_message_filter.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 15 chunks +26 lines, -20 lines 0 comments Download
M content/browser/renderer_host/render_view_host_impl.cc View 1 2 chunks +4 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.cc View 1 3 chunks +4 lines, -3 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.cc View 1 2 chunks +5 lines, -3 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_browsertest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.mm View 1 2 chunks +4 lines, -2 lines 0 comments Download
M content/browser/service_worker/service_worker_browsertest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/site_instance_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/site_instance_impl_unittest.cc View 5 chunks +6 lines, -5 lines 0 comments Download
M content/browser/tracing/tracing_ui.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/utility_process_host_impl.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M content/browser/web_contents/web_contents_view_aura.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/zygote_host/zygote_host_impl_linux.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M content/child/child_thread.cc View 4 chunks +7 lines, -6 lines 0 comments Download
M content/child/npapi/npobject_stub.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/child/runtime_features.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/common/child_process_host_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/content_switches_internal.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/common/gpu/client/gl_helper_benchmark.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/gpu/client/gl_helper_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/gpu/gpu_channel.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/common/gpu/gpu_memory_manager.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/common/gpu/image_transport_surface_android.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/common/gpu/media/android_video_encode_accelerator.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/gpu/media/gpu_video_encode_accelerator.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/gpu/media/rendering_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/gpu/media/v4l2_video_encode_accelerator.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/gpu/media/vaapi_h264_decoder_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M content/common/gpu/media/vaapi_video_encode_accelerator.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/gpu/media/video_decode_accelerator_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M content/common/gpu/media/video_encode_accelerator_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M content/common/gpu/texture_image_transport_surface.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/common/handle_enumerator_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/pepper_plugin_list.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M content/common/plugin_list.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/sandbox_init_mac.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/common/sandbox_init_win.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/common/sandbox_linux/bpf_gpu_policy_linux.cc View 2 chunks +9 lines, -7 lines 0 comments Download
M content/common/sandbox_linux/sandbox_linux.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M content/common/sandbox_linux/sandbox_seccomp_bpf_linux.cc View 6 chunks +10 lines, -6 lines 0 comments Download
M content/common/sandbox_mac.mm View 1 chunk +2 lines, -1 line 0 comments Download
M content/common/sandbox_win.cc View 5 chunks +10 lines, -7 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
brettw
6 years, 4 months ago (2014-08-07 23:58:28 UTC) #1
brettw
6 years, 4 months ago (2014-08-11 20:32:18 UTC) #2
Message was sent while issue was closed. 
Committed patchset #2 manually as 288787 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698