Issue 456383003: relax quadratic binary search test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 456383003: relax quadratic binary search test (Closed)

Created:
6 years, 4 months ago by caryclark

Modified:
6 years, 4 months ago

Reviewers:

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

More Reviews

Description

relax quadratic binary search test Extreme implicit quartic equations solve to roots that are different enough that they appear to have failed. In this case, fall back on binary searching to find an intersection. Relax the condition when this happens; don't give up just because the computed implicit root points aren't remotely the same. TBR=reed BUG=skia:2808 Committed: https://skia.googlesource.com/skia/+/80a83adaf2f8db849bfae288e31b7c789dafabf5

Patch Set 1 #

Patch Set 2 : clean up temporary test scaffolding #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+167 lines, -136 lines)			Patch
M	src/pathops/SkDQuadIntersection.cpp	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	tests/PathOpsOpTest.cpp	View	1	2 chunks	+29 lines, -0 lines	0 comments	Download
M	tests/PathOpsQuadIntersectionTest.cpp	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	tools/pathops_visualizer.htm	View		2 chunks	+133 lines, -134 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/caryclark@google.com/456383003/20001

6 years, 4 months ago (2014-08-12 12:41:06 UTC) #2

commit-bot: I haz the power

6 years, 4 months ago (2014-08-12 12:49:47 UTC) #3

Message was sent while issue was closed.

Change committed as 80a83adaf2f8db849bfae288e31b7c789dafabf5

Expand Messages | Collapse Messages