Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 456333002: Move MachineRepresentation to machine-type.h and rename to MachineType in preparation for merging i… (Closed)

Created:
6 years, 4 months ago by titzer
Modified:
6 years, 4 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Move MachineRepresentation to machine-type.h and rename to MachineType in preparation for merging it with RepType. R=bmeurer@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=23051

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+204 lines, -216 lines) Patch
M src/compiler/arm/instruction-selector-arm.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/compiler/arm/linkage-arm.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler/arm64/instruction-selector-arm64.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/compiler/arm64/linkage-arm64.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler/ia32/instruction-selector-ia32.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/compiler/ia32/linkage-ia32.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler/instruction-selector.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/instruction-selector.cc View 3 chunks +6 lines, -7 lines 0 comments Download
M src/compiler/linkage.h View 1 2 chunks +5 lines, -5 lines 0 comments Download
M src/compiler/linkage.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler/linkage-impl.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M src/compiler/machine-node-factory.h View 4 chunks +11 lines, -14 lines 0 comments Download
M src/compiler/machine-operator.h View 6 chunks +10 lines, -32 lines 0 comments Download
A src/compiler/machine-type.h View 1 chunk +36 lines, -0 lines 0 comments Download
M src/compiler/raw-machine-assembler.h View 3 chunks +5 lines, -6 lines 0 comments Download
M src/compiler/raw-machine-assembler.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/representation-change.h View 3 chunks +5 lines, -5 lines 0 comments Download
M src/compiler/simplified-lowering.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M src/compiler/simplified-operator.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/compiler/structured-machine-assembler.h View 3 chunks +3 lines, -4 lines 0 comments Download
M src/compiler/structured-machine-assembler.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/x64/instruction-selector-x64.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/compiler/x64/linkage-x64.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M test/cctest/compiler/call-tester.h View 10 chunks +26 lines, -34 lines 0 comments Download
M test/cctest/compiler/codegen-tester.h View 6 chunks +18 lines, -20 lines 0 comments Download
M test/cctest/compiler/graph-builder-tester.h View 2 chunks +6 lines, -7 lines 0 comments Download
M test/cctest/compiler/graph-builder-tester.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M test/cctest/compiler/instruction-selector-tester.h View 1 chunk +2 lines, -3 lines 0 comments Download
M test/cctest/compiler/test-changes-lowering.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/compiler/test-codegen-deopt.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M test/cctest/compiler/test-run-machops.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M test/cctest/compiler/test-simplified-lowering.cc View 1 7 chunks +14 lines, -15 lines 0 comments Download
M test/compiler-unittests/instruction-selector-unittest.h View 2 chunks +11 lines, -19 lines 0 comments Download
M tools/gyp/v8.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
titzer
6 years, 4 months ago (2014-08-11 09:58:32 UTC) #1
Benedikt Meurer
lgtm
6 years, 4 months ago (2014-08-11 10:01:02 UTC) #2
titzer
6 years, 4 months ago (2014-08-11 15:55:49 UTC) #3
Message was sent while issue was closed. 
Committed patchset #2 manually as 23051 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698