Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1104)

Unified Diff: src/compiler/representation-change.h

Issue 456333002: Move MachineRepresentation to machine-type.h and rename to MachineType in preparation for merging i… (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/raw-machine-assembler.cc ('k') | src/compiler/simplified-lowering.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/representation-change.h
diff --git a/src/compiler/representation-change.h b/src/compiler/representation-change.h
index 255073003d6c588e616aef0bfe4f06e9528718ae..94225bb2ef2d0c09e83f12acef2ca0aa4ccd8ca4 100644
--- a/src/compiler/representation-change.h
+++ b/src/compiler/representation-change.h
@@ -16,7 +16,7 @@ namespace compiler {
// The types and representations tracked during representation inference
// and change insertion.
-// TODO(titzer): First, merge MachineRepresentation and RepType.
+// TODO(titzer): First, merge MachineType and RepType.
// TODO(titzer): Second, Use the real type system instead of RepType.
enum RepType {
// Representations.
@@ -265,8 +265,8 @@ class RepresentationChanger {
return TypeError(node, output_type, rWord64);
}
- static RepType TypeForMachineRepresentation(MachineRepresentation rep) {
- // TODO(titzer): merge MachineRepresentation and RepType.
+ static RepType TypeForMachineType(MachineType rep) {
+ // TODO(titzer): merge MachineType and RepType.
switch (rep) {
case kMachineWord8:
return rWord32;
@@ -348,13 +348,13 @@ class RepresentationChanger {
RepType TypeForField(const FieldAccess& access) {
RepType tElement = static_cast<RepType>(0); // TODO(titzer)
- RepType rElement = TypeForMachineRepresentation(access.representation);
+ RepType rElement = TypeForMachineType(access.representation);
return static_cast<RepType>(tElement | rElement);
}
RepType TypeForElement(const ElementAccess& access) {
RepType tElement = static_cast<RepType>(0); // TODO(titzer)
- RepType rElement = TypeForMachineRepresentation(access.representation);
+ RepType rElement = TypeForMachineType(access.representation);
return static_cast<RepType>(tElement | rElement);
}
« no previous file with comments | « src/compiler/raw-machine-assembler.cc ('k') | src/compiler/simplified-lowering.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698