Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(649)

Unified Diff: runtime/vm/profiler.cc

Issue 455873002: Disable ProfilerNativeStackWalker on Win64 (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/profiler.cc
diff --git a/runtime/vm/profiler.cc b/runtime/vm/profiler.cc
index 83e2235f51636015c73abf847d78940388e50d31..565aa9183c999ef5b945222c9e0e61319f732bb5 100644
--- a/runtime/vm/profiler.cc
+++ b/runtime/vm/profiler.cc
@@ -2086,6 +2086,11 @@ void Profiler::RecordSampleInterruptCallback(
state.sp);
stackWalker.walk();
} else {
+#if defined(TARGET_OS_WINDOWS) && defined(TARGET_ARCH_X64)
+ // ProfilerNativeStackWalker is known to cause crashes on Win64.
+ // BUG=20423.
+ sample->set_ignore_sample(true);
+#else
// Fall back to an extremely conservative stack walker.
ProfilerNativeStackWalker stackWalker(sample,
stack_lower,
@@ -2094,6 +2099,7 @@ void Profiler::RecordSampleInterruptCallback(
state.fp,
state.sp);
stackWalker.walk();
+#endif
}
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698