Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Side by Side Diff: runtime/vm/profiler.cc

Issue 455873002: Disable ProfilerNativeStackWalker on Win64 (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "platform/utils.h" 5 #include "platform/utils.h"
6 6
7 #include "vm/allocation.h" 7 #include "vm/allocation.h"
8 #include "vm/atomic.h" 8 #include "vm/atomic.h"
9 #include "vm/code_patcher.h" 9 #include "vm/code_patcher.h"
10 #include "vm/isolate.h" 10 #include "vm/isolate.h"
(...skipping 2068 matching lines...) Expand 10 before | Expand all | Expand 10 after
2079 // We are executing Dart code. We have frame pointers. 2079 // We are executing Dart code. We have frame pointers.
2080 ProfilerDartStackWalker stackWalker(isolate, 2080 ProfilerDartStackWalker stackWalker(isolate,
2081 sample, 2081 sample,
2082 stack_lower, 2082 stack_lower,
2083 stack_upper, 2083 stack_upper,
2084 state.pc, 2084 state.pc,
2085 state.fp, 2085 state.fp,
2086 state.sp); 2086 state.sp);
2087 stackWalker.walk(); 2087 stackWalker.walk();
2088 } else { 2088 } else {
2089 #if defined(TARGET_OS_WINDOWS) && defined(TARGET_ARCH_X64)
2090 // ProfilerNativeStackWalker is known to cause crashes on Win64.
2091 // BUG=20423.
2092 sample->set_ignore_sample(true);
2093 #else
2089 // Fall back to an extremely conservative stack walker. 2094 // Fall back to an extremely conservative stack walker.
2090 ProfilerNativeStackWalker stackWalker(sample, 2095 ProfilerNativeStackWalker stackWalker(sample,
2091 stack_lower, 2096 stack_lower,
2092 stack_upper, 2097 stack_upper,
2093 state.pc, 2098 state.pc,
2094 state.fp, 2099 state.fp,
2095 state.sp); 2100 state.sp);
2096 stackWalker.walk(); 2101 stackWalker.walk();
2102 #endif
2097 } 2103 }
2098 } 2104 }
2099 } 2105 }
2100 2106
2101 } // namespace dart 2107 } // namespace dart
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698