Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Unified Diff: webkit/common/gpu/webgraphicscontext3d_in_process_command_buffer_impl.h

Issue 455783002: GPU context creation code duplication cleanup (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkgr
Patch Set: Fix even more build dependencies Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webkit/common/gpu/webgraphicscontext3d_in_process_command_buffer_impl.h
diff --git a/webkit/common/gpu/webgraphicscontext3d_in_process_command_buffer_impl.h b/webkit/common/gpu/webgraphicscontext3d_in_process_command_buffer_impl.h
index 5ab1a1728d4d94ae53c0098204bb6245a41ac907..54d7f17ab8b2d89a79141940e3573123b8ec9340 100644
--- a/webkit/common/gpu/webgraphicscontext3d_in_process_command_buffer_impl.h
+++ b/webkit/common/gpu/webgraphicscontext3d_in_process_command_buffer_impl.h
@@ -22,12 +22,12 @@ class ContextSupport;
namespace gles2 {
class GLES2Interface;
class GLES2Implementation;
+struct ContextCreationAttribHelper;
}
}
namespace gpu {
class GLInProcessContext;
-struct GLInProcessContextAttribs;
}
namespace webkit {
@@ -54,12 +54,6 @@ class WEBKIT_GPU_EXPORT WebGraphicsContext3DInProcessCommandBufferImpl
virtual ~WebGraphicsContext3DInProcessCommandBufferImpl();
- // Convert WebGL context creation attributes into GLInProcessContext / EGL
- // size requests.
- static void ConvertAttributes(
- const blink::WebGraphicsContext3D::Attributes& attributes,
- ::gpu::GLInProcessContextAttribs* output_attribs);
-
//----------------------------------------------------------------------
// WebGraphicsContext3D methods
virtual bool makeContextCurrent();
@@ -90,7 +84,7 @@ class WEBKIT_GPU_EXPORT WebGraphicsContext3DInProcessCommandBufferImpl
// instead of going through WebGraphicsContext3D.
void ClearContext();
- ::gpu::GLInProcessContextAttribs attribs_;
+ ::gpu::gles2::ContextCreationAttribHelper attribs_;
bool share_resources_;
bool webgl_context_;

Powered by Google App Engine
This is Rietveld 408576698