Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Unified Diff: webkit/common/gpu/webgraphicscontext3d_impl.cc

Issue 455783002: GPU context creation code duplication cleanup (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkgr
Patch Set: Fix even more build dependencies Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webkit/common/gpu/webgraphicscontext3d_impl.cc
diff --git a/webkit/common/gpu/webgraphicscontext3d_impl.cc b/webkit/common/gpu/webgraphicscontext3d_impl.cc
index 86df14a797384b2e3dfe7a369dd61767ebd7438d..abf9d954b8c5c71cb13cd5f1ec611cf6f85cd6b1 100644
--- a/webkit/common/gpu/webgraphicscontext3d_impl.cc
+++ b/webkit/common/gpu/webgraphicscontext3d_impl.cc
@@ -10,6 +10,7 @@
#include "gpu/GLES2/gl2extchromium.h"
#include "gpu/command_buffer/client/gles2_implementation.h"
#include "gpu/command_buffer/client/gles2_lib.h"
+#include "gpu/command_buffer/common/gles2_cmd_utils.h"
#include "gpu/skia_bindings/gl_bindings_skia_cmd_buffer.h"
#include "third_party/khronos/GLES2/gl2.h"
@@ -980,5 +981,19 @@ void WebGraphicsContext3DImpl::copyTextureToParentTextureCHROMIUM(
void WebGraphicsContext3DImpl::releaseShaderCompiler() {
}
+// static
+void WebGraphicsContext3DImpl::ConvertAttributes(
+ const blink::WebGraphicsContext3D::Attributes& attributes,
+ ::gpu::gles2::ContextCreationAttribHelper* output_attribs) {
+ output_attribs->alpha_size = attributes.alpha ? 8 : 0;
+ output_attribs->depth_size = attributes.depth ? 24 : 0;
+ output_attribs->stencil_size = attributes.stencil ? 8 : 0;
+ output_attribs->samples = attributes.antialias ? 4 : 0;
+ output_attribs->sample_buffers = attributes.antialias ? 1 : 0;
+ output_attribs->fail_if_major_perf_caveat =
+ attributes.failIfMajorPerformanceCaveat;
+ output_attribs->bind_generates_resource = false;
+}
+
} // namespace gpu
} // namespace webkit
« no previous file with comments | « webkit/common/gpu/webgraphicscontext3d_impl.h ('k') | webkit/common/gpu/webgraphicscontext3d_in_process_command_buffer_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698