Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 455743002: Enable ES6 unscopables (Closed)

Created:
6 years, 4 months ago by rossberg
Modified:
6 years, 4 months ago
Reviewers:
Yang
CC:
v8-dev, arv (Not doing code reviews)
Project:
v8
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -718 lines) Patch
M src/array.js View 1 chunk +14 lines, -0 lines 0 comments Download
M src/bootstrapper.cc View 3 chunks +1 line, -5 lines 0 comments Download
M src/contexts.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/flag-definitions.h View 2 chunks +0 lines, -2 lines 0 comments Download
M src/symbol.js View 1 chunk +2 lines, -2 lines 0 comments Download
D src/unscopables.js View 1 chunk +0 lines, -39 lines 0 comments Download
M test/cctest/test-unscopables-hidden-prototype.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M test/mjsunit/es6/symbols.js View 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/es6/unscopables.js View 0 chunks +-1 lines, --1 lines 0 comments Download
D test/mjsunit/harmony/unscopables.js View 1 chunk +0 lines, -664 lines 0 comments Download
M tools/generate-runtime-tests.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/gyp/v8.gyp View 3 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
rossberg
6 years, 4 months ago (2014-08-08 11:12:58 UTC) #1
Yang
On 2014/08/08 11:12:58, rossberg wrote: lgtm.
6 years, 4 months ago (2014-08-08 11:33:48 UTC) #2
rossberg
6 years, 4 months ago (2014-08-08 11:43:12 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as 22994 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698