Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(614)

Issue 455583002: Port parts of //third_pary/libjingle build to GN (Closed)

Created:
6 years, 4 months ago by rlarocque
Modified:
6 years, 3 months ago
Reviewers:
awong
CC:
chromium-reviews, benquan, browser-components-watch_chromium.org, jam, darin-cc_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org, brettw
Project:
chromium
Visibility:
Public.

Description

Port parts of //third_pary/libjingle build to GN Reimplements parts of //third_party/libjingle's build in GN. The new build is much less flexible than the original. Some flags are not supported. Some windows-specific configs have been left out and annotated with TODOs. Most signifcantly, the entirety of the 'if (enable_webrtc)' block has been omitted, because the GN build for webrtc isn't working yet. Despite these limitations, it is an adequate replacement for the 'stub' libjingle target in most situations. BUG=

Patch Set 1 #

Patch Set 2 : More comments #

Patch Set 3 : Rebase #

Patch Set 4 : Another rebase #

Total comments: 4

Patch Set 5 : Small includes fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+377 lines, -39 lines) Patch
M BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/BUILD.gn View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M chrome/service/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/content/browser/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/BUILD.gn View 3 chunks +2 lines, -6 lines 0 comments Download
M components/invalidation/BUILD.gn View 1 chunk +0 lines, -3 lines 0 comments Download
M content/common/BUILD.gn View 2 chunks +1 line, -3 lines 0 comments Download
M content/renderer/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download
M jingle/BUILD.gn View 3 chunks +6 lines, -19 lines 0 comments Download
A third_party/libjingle/BUILD.gn View 1 2 3 4 1 chunk +350 lines, -0 lines 0 comments Download
M third_party/libjingle/libjingle.gyp View 1 6 chunks +10 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
rlarocque
Here's the third_party/libjingle GN work I've done so far. I had to avoid importing any ...
6 years, 4 months ago (2014-08-08 19:17:08 UTC) #1
tfarina
You say WebRTC breaks the build. Is there a bug filed for this? Is Henrik ...
6 years, 4 months ago (2014-08-08 19:50:52 UTC) #2
rlarocque
On 2014/08/08 19:50:52, tfarina wrote: > You say WebRTC breaks the build. Is there a ...
6 years, 4 months ago (2014-08-08 20:03:36 UTC) #3
awong
Need to review more but had 2 comments I wanted to send first. https://codereview.chromium.org/455583002/diff/60001/third_party/libjingle/BUILD.gn File ...
6 years, 4 months ago (2014-08-08 21:53:15 UTC) #4
rlarocque
https://codereview.chromium.org/455583002/diff/60001/third_party/libjingle/BUILD.gn File third_party/libjingle/BUILD.gn (right): https://codereview.chromium.org/455583002/diff/60001/third_party/libjingle/BUILD.gn#newcode8 third_party/libjingle/BUILD.gn:8: libjingle_source = "source" On 2014/08/08 21:53:15, awong wrote: > ...
6 years, 4 months ago (2014-08-09 00:01:11 UTC) #5
kjellander_chromium
6 years, 4 months ago (2014-08-14 06:12:53 UTC) #6
On 2014/08/08 19:50:52, tfarina wrote:
> You say WebRTC breaks the build. Is there a bug filed for this? Is Henrik
aware
> of this?
> 
> Henrik and Brett fyi.

It's correct that all of WebRTC that Chromium uses is not ready for GN yet. 
This is tracked in http://code.google.com/p/webrtc/issues/detail?id=3441
I have a CL prepared in https://codereview.chromium.org/321313006/ that enables
//third_party/webrtc in src/BUILD.gn, 
but I still haven't caught up with recent changes (like the boringssl switch) in
the GN files, since I'm on parental leave.

Powered by Google App Engine
This is Rietveld 408576698