Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 321313006: Enable building WebRTC with GN. (Closed)

Created:
6 years, 6 months ago by kjellander_chromium
Modified:
6 years, 3 months ago
Reviewers:
brettw
CC:
chromium-reviews
Visibility:
Public.

Description

Enable building WebRTC with GN. This CL depends on the following CL to be landed first: https://webrtc-codereview.appspot.com/15989004 with the addition that that WebRTC revision of it needs to be be rolled into Chromium DEPS first. BUG=webrtc:3441 TEST=See https://webrtc-codereview.appspot.com/15989004 for details. Committed: https://crrev.com/91966d30b3d11da8437d8499440e5bb7555b4530 Cr-Commit-Position: refs/heads/master@{#291688}

Patch Set 1 #

Patch Set 2 : Rebased #

Patch Set 3 : Rebased #

Patch Set 4 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M BUILD.gn View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
brettw
lgtm
6 years, 6 months ago (2014-06-11 17:26:06 UTC) #1
kjellander_chromium
I'm waiting for https://code.google.com/p/webrtc/source/detail?r=6560 to be rolled in to webrtc_revision of Chromium's DEPS before trying ...
6 years, 5 months ago (2014-07-02 07:42:40 UTC) #2
kjellander_chromium
On 2014/07/02 07:42:40, kjellander (OOO til Aug 4) wrote: > I'm waiting for https://code.google.com/p/webrtc/source/detail?r=6560 to ...
6 years, 5 months ago (2014-07-04 11:03:42 UTC) #3
kjellander_chromium
The CQ bit was checked by kjellander@chromium.org
6 years, 4 months ago (2014-08-25 15:13:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kjellander@chromium.org/321313006/80001
6 years, 4 months ago (2014-08-25 15:14:16 UTC) #5
commit-bot: I haz the power
Committed patchset #4 (80001) as 192f92ed2d454213cafd61d2dc2fb45bdf6e190a
6 years, 4 months ago (2014-08-25 16:08:11 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:34:44 UTC) #7
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/91966d30b3d11da8437d8499440e5bb7555b4530
Cr-Commit-Position: refs/heads/master@{#291688}

Powered by Google App Engine
This is Rietveld 408576698