Add MobileUsingMenuBy* metric actions owner and remove an unused one.

Add MobileUsingMenuBy* metric actions owner and remove an unused one.

BUG=401821
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288434

[Alexei Svitkine (slow), 2014-08-08 15:20:49]

https://codereview.chromium.org/455543003/diff/1/chrome/browser/android/uma_b...
File chrome/browser/android/uma_bridge.cc (left):

https://codereview.chromium.org/455543003/diff/1/chrome/browser/android/uma_b...
chrome/browser/android/uma_bridge.cc:26:
RecordAction(UserMetricsAction("MobileUsingMenuByHwButtonDragging"));
According to the counts dashboard, we have seen samples for this action:

https://uma.googleplex.com/counts

So the new NOTREACHED() statement will be reached. (Unless some other code
changes since then.)

https://codereview.chromium.org/455543003/diff/1/tools/metrics/actions/action...
File tools/metrics/actions/actions.xml (left):

https://codereview.chromium.org/455543003/diff/1/tools/metrics/actions/action...
tools/metrics/actions/actions.xml:7541: <action
name="MobileUsingMenuByHwButtonDragging">
Please keep this action since we have samples on it on the dashboard. (Even if
you choose to remove it from the code, it should still be kept in this file and
marked obsolete.)

[Kibeom Kim (inactive), 2014-08-08 18:29:15]

https://codereview.chromium.org/455543003/diff/1/chrome/browser/android/uma_b...
File chrome/browser/android/uma_bridge.cc (left):

https://codereview.chromium.org/455543003/diff/1/chrome/browser/android/uma_b...
chrome/browser/android/uma_bridge.cc:26:
RecordAction(UserMetricsAction("MobileUsingMenuByHwButtonDragging"));
On 2014/08/08 15:20:49, Alexei Svitkine wrote:
> According to the counts dashboard, we have seen samples for this action:
> 
> https://uma.googleplex.com/counts
> 
> So the new NOTREACHED() statement will be reached. (Unless some other code
> changes since then.)
> 

I removed HW dragging code recently.

https://codereview.chromium.org/455543003/diff/1/tools/metrics/actions/action...
File tools/metrics/actions/actions.xml (left):

https://codereview.chromium.org/455543003/diff/1/tools/metrics/actions/action...
tools/metrics/actions/actions.xml:7541: <action
name="MobileUsingMenuByHwButtonDragging">
On 2014/08/08 15:20:49, Alexei Svitkine wrote:
> Please keep this action since we have samples on it on the dashboard. (Even if
> you choose to remove it from the code, it should still be kept in this file
and
> marked obsolete.)

I removed HW menu dragging recently, https://codereview.chromium.org/319943003/
should we still keep this action here and mark it obsolete?

[Alexei Svitkine (slow), 2014-08-08 18:31:44]

https://codereview.chromium.org/455543003/diff/1/tools/metrics/actions/action...
File tools/metrics/actions/actions.xml (left):

https://codereview.chromium.org/455543003/diff/1/tools/metrics/actions/action...
tools/metrics/actions/actions.xml:7541: <action
name="MobileUsingMenuByHwButtonDragging">
On 2014/08/08 18:29:15, Kibeom Kim wrote:
> On 2014/08/08 15:20:49, Alexei Svitkine wrote:
> > Please keep this action since we have samples on it on the dashboard. (Even
if
> > you choose to remove it from the code, it should still be kept in this file
> and
> > marked obsolete.)
> 
> I removed HW menu dragging recently,
https://codereview.chromium.org/319943003/
> should we still keep this action here and mark it obsolete?

Yes, please.

[Kibeom Kim (inactive), 2014-08-08 18:44:06]

https://codereview.chromium.org/455543003/diff/1/tools/metrics/actions/action...
File tools/metrics/actions/actions.xml (left):

https://codereview.chromium.org/455543003/diff/1/tools/metrics/actions/action...
tools/metrics/actions/actions.xml:7541: <action
name="MobileUsingMenuByHwButtonDragging">
On 2014/08/08 18:31:44, Alexei Svitkine wrote:
> On 2014/08/08 18:29:15, Kibeom Kim wrote:
> > On 2014/08/08 15:20:49, Alexei Svitkine wrote:
> > > Please keep this action since we have samples on it on the dashboard.
(Even
> if
> > > you choose to remove it from the code, it should still be kept in this
file
> > and
> > > marked obsolete.)
> > 
> > I removed HW menu dragging recently,
> https://codereview.chromium.org/319943003/
> > should we still keep this action here and mark it obsolete?
> 
> Yes, please.

Done.

[Alexei Svitkine (slow), 2014-08-08 19:05:44]

LGTM

[Kibeom Kim (inactive), 2014-08-08 19:09:01]

The CQ bit was checked by kkimlabs@chromium.org

[commit-bot: I haz the power, 2014-08-08 19:12:19]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/kkimlabs@chromium.org/455543003/20001

[Kibeom Kim (inactive), 2014-08-08 20:35:07]

+ OWNER tedchoc@ for
chrome/browser/android/uma_bridge.cc

[Ted C, 2014-08-08 20:36:02]

lgtm

[commit-bot: I haz the power, 2014-08-08 20:58:47]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[commit-bot: I haz the power, 2014-08-08 21:16:32]

Change committed as 288434