chrome/browser/android/uma_bridge.cc - Issue 455543003: Add MobileUsingMenuBy* metric actions owner and remove an unused one.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/uma_bridge.cc

Issue 455543003: Add MobileUsingMenuBy* metric actions owner and remove an unused one. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: added <action name="MobileUsingMenuByHwButtonDragging"> back Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/android/uma_bridge.cc

diff --git a/chrome/browser/android/uma_bridge.cc b/chrome/browser/android/uma_bridge.cc

index 614b626d837f8790e95649a2e4132383df723613..ab345bb45aa64e4590c6c4dc21b6337c1a9c8ba8 100644

--- a/chrome/browser/android/uma_bridge.cc

+++ b/chrome/browser/android/uma_bridge.cc

@@ -23,7 +23,7 @@ static void RecordUsingMenu(JNIEnv*,

jboolean is_dragging) {

if (is_by_hw_button) {

if (is_dragging) {

- RecordAction(UserMetricsAction("MobileUsingMenuByHwButtonDragging"));

+ NOTREACHED() << "We do not support dragging for hardware menu button.";

} else {

RecordAction(UserMetricsAction("MobileUsingMenuByHwButtonTap"));

}

« no previous file with comments | « no previous file | tools/metrics/actions/actions.xml » ('j') | no next file with comments »