Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1192)

Issue 455463002: Revert of Define SK_PICTURE_CLONE_NOOP. (Closed)

Created:
6 years, 4 months ago by Albert Bodenhamer
Modified:
6 years, 4 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Define SK_PICTURE_CLONE_NOOP. (https://codereview.chromium.org/445373003/) Reason for revert: This looks like the most likely culprit for the crash in http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29/builds/32814. Partial stack dump: [16752:16752:0807/140640:WARNING:password_store_factory.cc(215)] Using basic (unencrypted) store for password storage. See http://code.google.com/p/chromium/wiki/LinuxPasswordStorage for more information about password storage options. [16783:16783:0807/140640:ERROR:sandbox_linux.cc(304)] InitializeSandbox() called with multiple threads in process gpu-process [16783:16783:0807/140640:WARNING:x11_util.cc(1408)] X error received: serial 61, error_code 8 (BadMatch (invalid parameter attributes)), request_code 72, minor_code 0 (X_PutImage) ASSERTION FAILED: info.fAlphaType == m_imageInfo.fAlphaType ../../third_party/WebKit/Source/platform/graphics/DecodingImageGenerator.cpp(78) : virtual bool blink::DecodingImageGenerator::onGetPixels(const SkImageInfo &, void *, size_t, SkPMColor *, int *) 1 0x7f11fbdbcdd8 2 0x7f11fb0ea18c SkImageGenerator::getPixels(SkImageInfo const&, void*, unsigned long, unsigned int*, int*) 3 0x7f11fb0bc349 4 0x7f11fb13e30b SkPixelRef::lockPixels(SkPixelRef::LockRec*) 5 0x7f11fb13e479 SkPixelRef::lockPixels() 6 0x7f11fb04a6ea SkBitmap::lockPixels() const 7 0x7f11fb05032d 8 0x7f11fb0c35ca 9 0x7f11fb051f51 SkBitmapDevice::drawBitmap(SkDraw const&, SkBitmap const&, SkMatrix const&, SkPaint const&) 10 0x7f11fb05223b SkBitmapDevice::drawBitmapRect(SkDraw const&, SkBitmap const&, SkRect const*, SkRect const&, SkPaint const&, SkCanvas::DrawBitmapRectFlags) 11 0x7f11fb0a3d4a SkCanvas::internalDrawBitmapRect(SkBitmap const&, SkRect const*, SkRect const&, SkPaint const*, SkCanvas::DrawBitmapRectFlags) 12 0x7f11fb0a3de1 SkCanvas::drawBitmapRectToRect(SkBitmap const&, SkRect const*, SkRect const&, SkPaint const*, SkCanvas::DrawBitmapRectFlags) 13 0x7f11fb12c296 14 0x7f11fb12b9e1 15 0x7f11fb12241f SkPicture::draw(SkCanvas*, SkDrawPictureCallback*) const 16 0x7f11fc67a2a7 cc::Picture::Raster(SkCanvas*, SkDrawPictureCallback*, cc::Region const&, float) 17 0x7f11fc6adc59 cc::PicturePileImpl::RasterCommon(SkCanvas*, SkDrawPictureCallback*, gfx::Rect const&, float, cc::RenderingStatsInstrumentation*, bool) 18 0x7f11fc6ae45e cc::PicturePileImpl::RasterToBitmap(SkCanvas*, gfx::Rect const&, float, cc::RenderingStatsInstrumentation*) Original issue's description: > Define SK_PICTURE_CLONE_NOOP. > > This makes SkPicture::clone() a cheap ref, meaning impl-side painting will render > tiles concurrently from the same source SkPicture rather than from clones. > > After testing for a few months in Skia, we believe SkPicture is thread safe enough > to try this out on the Chrome bots. Please revert this at the slightest sign of > crash, flaky drawing, etc. > > CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_layout_rel > > BUG= > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288096 TBR=reed@google.com,robertphillips@google.com,mtklein@google.com,mtklein@chromium.org NOTREECHECKS=true NOTRY=true BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288190

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M skia/config/SkUserConfig.h View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Albert Bodenhamer
Created Revert of Define SK_PICTURE_CLONE_NOOP.
6 years, 4 months ago (2014-08-07 21:25:12 UTC) #1
mtklein
On 2014/08/07 21:25:12, Albert Bodenhamer wrote: > Created Revert of Define SK_PICTURE_CLONE_NOOP. Agreed it's the ...
6 years, 4 months ago (2014-08-07 21:27:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abodenha@chromium.org/455463002/1
6 years, 4 months ago (2014-08-07 21:41:25 UTC) #3
commit-bot: I haz the power
Change committed as 288190
6 years, 4 months ago (2014-08-08 01:10:57 UTC) #4
mtklein
6 years, 4 months ago (2014-08-08 02:16:20 UTC) #5
Message was sent while issue was closed.
On 2014/08/08 01:10:57, I haz the power (commit-bot) wrote:
> Change committed as 288190

I'm going to try relanding the original CL.  Looking at the build logs, this
must be a flaky test:

32814  - build with original CL, failed
32815  - subsequent build, passed
32816  - another build, passed
32817  - build with revert, still running

http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29...

Powered by Google App Engine
This is Rietveld 408576698