Source/modules/webaudio/AudioNode.h - Issue 455353002: Add an ASSERT to verify that AudioNode::dispose() is always called

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/webaudio/AudioNode.h

Issue 455353002: Add an ASSERT to verify that AudioNode::dispose() is always called (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/modules/webaudio/AudioNode.h

diff --git a/Source/modules/webaudio/AudioNode.h b/Source/modules/webaudio/AudioNode.h

index fc67044cf42d9c431d917dc1872598922572b34b..10b4940c925978323cea10f60eb50e6960de321f 100644

--- a/Source/modules/webaudio/AudioNode.h

+++ b/Source/modules/webaudio/AudioNode.h

@@ -228,6 +228,10 @@ private:

bool m_isMarkedForDeletion;

bool m_isDisabled;

+#ifndef NDEBUG

tkent 2014/08/11 10:13:06 should be |#if ENABLE(ASSERT)|. We have a bot wit

+ bool m_disposeIsCalled;

tkent 2014/08/11 10:13:06 m_disposeWasCalled, or m_didCallDispose?

haraken 2014/08/11 10:33:00 Done.

+#endif

#if DEBUG_AUDIONODE_REFERENCES

static bool s_isNodeCountInitialized;

static int s_nodeCount[NodeTypeEnd];