Add an ASSERT to verify that AudioNode::dispose() is always called

Source/modules/webaudio/AudioNode.h

 /*
  * Copyright (C) 2010, Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1.  Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 210 matching lines @@
 
 #if !ENABLE(OILPAN)
     // Ref-counting
     volatile int m_normalRefCount;
 #endif
     volatile int m_connectionRefCount;
 
     bool m_isMarkedForDeletion;
     bool m_isDisabled;
 
+#ifndef NDEBUG

[tkent, 2014/08/11 10:13:06]

should be |#if ENABLE(ASSERT)|.

We have a bot with Release + assertion.

+    bool m_disposeIsCalled;

[tkent, 2014/08/11 10:13:06]

m_disposeWasCalled, or m_didCallDispose?

[haraken, 2014/08/11 10:33:00]

Done.

+#endif
+
 #if DEBUG_AUDIONODE_REFERENCES
     static bool s_isNodeCountInitialized;
     static int s_nodeCount[NodeTypeEnd];
 #endif
     static unsigned s_instanceCount;
 
 #if !ENABLE(OILPAN)
     virtual void refEventTarget() OVERRIDE FINAL { ref(); }
     virtual void derefEventTarget() OVERRIDE FINAL { deref(); }
 #endif
 
 protected:
     unsigned m_channelCount;
     ChannelCountMode m_channelCountMode;
     AudioBus::ChannelInterpretation m_channelInterpretation;
 };
 
 } // namespace blink
 
 #endif // AudioNode_h