Add an ASSERT to verify that AudioNode::dispose() is always called

Add an ASSERT to verify that AudioNode::dispose() is always called

AudioNode::dispose() must be called before the AudioNode is destructed.
This is currently guaranteed in both oilpan builds and non-oilpan builds.
However the logic is not trivial, so this CL adds the ASSERT about it.

BUG=340522
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179941

[haraken, 2014-08-11 09:17:37]

PTAL

[tkent, 2014-08-11 10:13:06]

https://codereview.chromium.org/455353002/diff/20001/Source/modules/webaudio/...
File Source/modules/webaudio/AudioNode.cpp (right):

https://codereview.chromium.org/455353002/diff/20001/Source/modules/webaudio/...
Source/modules/webaudio/AudioNode.cpp:61: #ifndef NDEBUG
#if ENABLE(ASSERT)

https://codereview.chromium.org/455353002/diff/20001/Source/modules/webaudio/...
Source/modules/webaudio/AudioNode.cpp:116: #ifndef NDEBUG
Ditto.

https://codereview.chromium.org/455353002/diff/20001/Source/modules/webaudio/...
File Source/modules/webaudio/AudioNode.h (right):

https://codereview.chromium.org/455353002/diff/20001/Source/modules/webaudio/...
Source/modules/webaudio/AudioNode.h:231: #ifndef NDEBUG
should be |#if ENABLE(ASSERT)|.

We have a bot with Release + assertion.

https://codereview.chromium.org/455353002/diff/20001/Source/modules/webaudio/...
Source/modules/webaudio/AudioNode.h:232: bool m_disposeIsCalled;
m_disposeWasCalled, or m_didCallDispose?

[haraken, 2014-08-11 10:33:00]

https://codereview.chromium.org/455353002/diff/20001/Source/modules/webaudio/...
File Source/modules/webaudio/AudioNode.cpp (right):

https://codereview.chromium.org/455353002/diff/20001/Source/modules/webaudio/...
Source/modules/webaudio/AudioNode.cpp:61: #ifndef NDEBUG
On 2014/08/11 10:13:06, tkent wrote:
> #if ENABLE(ASSERT)

Done.

https://codereview.chromium.org/455353002/diff/20001/Source/modules/webaudio/...
File Source/modules/webaudio/AudioNode.h (right):

https://codereview.chromium.org/455353002/diff/20001/Source/modules/webaudio/...
Source/modules/webaudio/AudioNode.h:232: bool m_disposeIsCalled;
On 2014/08/11 10:13:06, tkent wrote:
> m_disposeWasCalled, or m_didCallDispose?

Done.

[tkent, 2014-08-11 10:52:07]

lgtm

[haraken, 2014-08-11 11:01:04]

The CQ bit was checked by haraken@chromium.org

[commit-bot: I haz the power, 2014-08-11 11:02:12]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/haraken@chromium.org/455353002/40001

[commit-bot: I haz the power, 2014-08-11 11:50:46]

Change committed as 179941