Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Unified Diff: tools/clang/blink_gc_plugin/tests/polymorphic_class_with_non_virtual_trace.h

Issue 455263004: Blink GC plugin: Ensure that classes with virtual trace methods always have vtables for their left-… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: CR Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/clang/blink_gc_plugin/tests/polymorphic_class_with_non_virtual_trace.h
diff --git a/tools/clang/blink_gc_plugin/tests/polymorphic_class_with_non_virtual_trace.h b/tools/clang/blink_gc_plugin/tests/polymorphic_class_with_non_virtual_trace.h
new file mode 100644
index 0000000000000000000000000000000000000000..3396c94553f5219cb6073bd9b81ad2da03f30f01
--- /dev/null
+++ b/tools/clang/blink_gc_plugin/tests/polymorphic_class_with_non_virtual_trace.h
@@ -0,0 +1,46 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef POLYMORPHIC_CLASS_WITH_NON_VIRTUAL_TRACE_H_
+#define POLYMORPHIC_CLASS_WITH_NON_VIRTUAL_TRACE_H_
+
+#include "heap/stubs.h"
+
+namespace blink {
+
+class HeapObject : public GarbageCollected<HeapObject> {
+public:
+ void trace(Visitor*) { }
+};
+
+class NonPolymorphicBase {
+};
+
+class PolymorphicBase {
+public:
+ virtual void foo();
+};
+
+class IsLeftMostPolymorphic
+ : public GarbageCollected<IsLeftMostPolymorphic>,
+ public PolymorphicBase {
+public:
+ void trace(Visitor*);
+private:
+ Member<HeapObject> m_obj;
+};
+
+class IsNotLeftMostPolymorphic
+ : public GarbageCollected<IsNotLeftMostPolymorphic>,
+ public NonPolymorphicBase,
+ public PolymorphicBase {
+public:
+ void trace(Visitor*);
+private:
+ Member<HeapObject> m_obj;
+};
+
+}
+
+#endif

Powered by Google App Engine
This is Rietveld 408576698