Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Unified Diff: tools/clang/blink_gc_plugin/tests/polymorphic_class_with_non_virtual_trace.cpp

Issue 455263004: Blink GC plugin: Ensure that classes with virtual trace methods always have vtables for their left-… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: CR Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/clang/blink_gc_plugin/tests/polymorphic_class_with_non_virtual_trace.cpp
diff --git a/tools/clang/blink_gc_plugin/tests/member_in_offheap_class.cpp b/tools/clang/blink_gc_plugin/tests/polymorphic_class_with_non_virtual_trace.cpp
similarity index 56%
copy from tools/clang/blink_gc_plugin/tests/member_in_offheap_class.cpp
copy to tools/clang/blink_gc_plugin/tests/polymorphic_class_with_non_virtual_trace.cpp
index 4b44c2d56e91b99161abf4092ba21e60750708b4..dc7620aa9c062258668db697fe72ea498e7f8fc7 100644
--- a/tools/clang/blink_gc_plugin/tests/member_in_offheap_class.cpp
+++ b/tools/clang/blink_gc_plugin/tests/polymorphic_class_with_non_virtual_trace.cpp
@@ -2,21 +2,16 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "member_in_offheap_class.h"
+#include "polymorphic_class_with_non_virtual_trace.h"
namespace blink {
-void OffHeapObject::trace(Visitor* visitor)
+void IsLeftMostPolymorphic::trace(Visitor* visitor)
{
visitor->trace(m_obj);
}
-void PartObject::trace(Visitor* visitor)
-{
- visitor->trace(m_obj);
-}
-
-void InlineObject::trace(Visitor* visitor)
+void IsNotLeftMostPolymorphic::trace(Visitor* visitor)
{
visitor->trace(m_obj);
}

Powered by Google App Engine
This is Rietveld 408576698