Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(731)

Unified Diff: Source/core/dom/Node.cpp

Issue 455223002: Make anchors mouse-focusable (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: De-duplicate using FocusController; update TestExpectations Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/dom/Node.cpp
diff --git a/Source/core/dom/Node.cpp b/Source/core/dom/Node.cpp
index 19c2cc0cfecd019f70ed76f2247f9c11b7588de5..854b0a66fb26c63f889446059c0fd219056d9a8e 100644
--- a/Source/core/dom/Node.cpp
+++ b/Source/core/dom/Node.cpp
@@ -82,6 +82,7 @@
#include "core/html/HTMLStyleElement.h"
#include "core/page/ContextMenuController.h"
#include "core/page/EventHandler.h"
+#include "core/page/FocusController.h"
#include "core/page/Page.h"
#include "core/frame/Settings.h"
#include "core/rendering/FlowThreadController.h"
@@ -2195,6 +2196,12 @@ void Node::defaultEventHandler(Event* event)
const AtomicString& eventType = event->type();
if (eventType == EventTypeNames::keydown || eventType == EventTypeNames::keypress) {
if (event->isKeyboardEvent()) {
+ if (eventType == EventTypeNames::keydown) {
+ if (Page* page = document().page()) {
+ if (page->focusController().setWasFocusedByMouse(false) && renderer())
+ renderer()->paintInvalidationForWholeRenderer();
pdr. 2014/08/12 02:02:22 Is this paintInvalidationForWholeRenderer() actual
pdr. 2014/08/12 02:18:54 Ignore me--this is needed after all.
+ }
+ }
if (LocalFrame* frame = document().frame())
frame->eventHandler().defaultKeyboardEventHandler(toKeyboardEvent(event));
}
@@ -2245,10 +2252,6 @@ void Node::defaultEventHandler(Event* event)
}
}
-void Node::willCallDefaultEventHandler(const Event&)
-{
-}
-
bool Node::willRespondToMouseMoveEvents()
{
if (isDisabledFormControl(this))

Powered by Google App Engine
This is Rietveld 408576698