Issue 455038: Give the proper error message in the case where you attempt to log int...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 455038: Give the proper error message in the case where you attempt to log int... (Closed)

Created:
11 years ago by Zachary Kuznia

Modified:
9 years, 7 months ago

Reviewers:
tim (not reviewing)

CC:
chromium-reviews_googlegroups.com, ncarter (slow), ben+cc_chromium.org, tim (not reviewing), idana

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Give the proper error message in the case where you attempt to log int o bookmark sync while offline. BUG=19738 TEST=Attempt to log in to bookmark sync while offline. The error should be "Connection Unavailable" Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=34279

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Created: 11 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -0 lines)			Patch
	M	chrome/browser/sync/engine/syncapi.cc	View		1 chunk	+6 lines, -0 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

tim (not reviewing)

11 years ago (2009-12-10 19:29:49 UTC) #2

LGTM

http://codereview.chromium.org/455038/diff/3001/2002
File chrome/browser/sync/engine/syncapi.cc (right):

http://codereview.chromium.org/455038/diff/3001/2002#newcode1439
chrome/browser/sync/engine/syncapi.cc:1439: browser_sync::ConnectionUnavailable)
{
ultranit - I never know what the style guide says for this but in this file (see
line 1022) we usually indent 4 spaces from the start of the line for similar
cases.

Expand Messages | Collapse Messages