Give the proper error message in the case where you attempt to log int...

chrome/browser/sync/engine/syncapi.cc

 // Copyright (c) 2006-2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/sync/engine/syncapi.h"
 
 #include "build/build_config.h"
 
 #if defined(OS_WIN)
 #include <windows.h>
@@ skipping 1417 matching lines @@
     case AuthWatcherEvent::GAIA_AUTH_FAILED:     // Invalid GAIA credentials.
       if (event.auth_results->auth_error == browser_sync::CaptchaRequired) {
         auth_problem_ = AuthError::CAPTCHA_REQUIRED;
         std::string url_string("http://www.google.com/accounts/");
         url_string += event.auth_results->captcha_url;
         GURL captcha(url_string);
         observer_->OnAuthError(AuthError::FromCaptchaChallenge(
             event.auth_results->captcha_token, captcha,
             GURL(event.auth_results->auth_error_url)));
         return;
+      } else if (event.auth_results->auth_error ==
+                     browser_sync::ConnectionUnavailable) {

[tim (not reviewing), 2009/12/10 19:29:49]

ultranit - I never know what the style guide says for this but in this file (see
line 1022) we usually indent 4 spaces from the start of the line for similar
cases.

+        auth_problem_ = AuthError::CONNECTION_FAILED;
+      } else {
+        auth_problem_ = AuthError::INVALID_GAIA_CREDENTIALS;
       }
+      break;
     case AuthWatcherEvent::SERVICE_AUTH_FAILED:  // Expired GAIA credentials.
       auth_problem_ = AuthError::INVALID_GAIA_CREDENTIALS;
       break;
     case AuthWatcherEvent::SERVICE_USER_NOT_SIGNED_UP:
       auth_problem_ = AuthError::USER_NOT_SIGNED_UP;
       break;
     case AuthWatcherEvent::SERVICE_CONNECTION_FAILED:
       auth_problem_ = AuthError::CONNECTION_FAILED;
       break;
     default:  // We don't care about the many other AuthWatcherEvent types.
@@ skipping 69 matching lines @@
 BaseTransaction::~BaseTransaction() {
   delete lookup_;
 }
 
 UserShare* SyncManager::GetUserShare() const {
   DCHECK(data_->initialized()) << "GetUserShare requires initialization!";
   return data_->GetUserShare();
 }
 
 }  // namespace sync_api