preemptive add new virtual for onDrawPicture

preemptive add new virtual for onDrawPicture

skia is changing the signature for onDrawPicture, so this CL adds the new one, and removes OVERRIDE from the old.

BUG=

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179885

[danakj, 2014-08-08 19:32:49]

https://codereview.chromium.org/454993002/diff/1/Source/platform/graphics/Log...
File Source/platform/graphics/LoggingCanvas.h (right):

https://codereview.chromium.org/454993002/diff/1/Source/platform/graphics/Log...
Source/platform/graphics/LoggingCanvas.h:75: virtual void onDrawPicture(const
SkPicture*, const SkMatrix*, const SkPaint*) OVERRIDE;
we don't use OVERRIDE on cross-repo (at least for blink) overrides for this
reason. maybe now's a good time to stop adding OVERRIDE to things that override
skia interfaces here.

[reed1, 2014-08-08 19:40:22]

https://codereview.chromium.org/454993002/diff/1/Source/platform/graphics/Log...
File Source/platform/graphics/LoggingCanvas.h (right):

https://codereview.chromium.org/454993002/diff/1/Source/platform/graphics/Log...
Source/platform/graphics/LoggingCanvas.h:75: virtual void onDrawPicture(const
SkPicture*, const SkMatrix*, const SkPaint*) OVERRIDE;
On 2014/08/08 19:32:49, danakj wrote:
> we don't use OVERRIDE on cross-repo (at least for blink) overrides for this
> reason. maybe now's a good time to stop adding OVERRIDE to things that
override
> skia interfaces here.

If true, that certainly makes it easier for skia.

I presume you're suggesting I can remove all the overrides in this file? If so,
I may do that in a separate CL, to not cloud the intent of this one.

[danakj, 2014-08-08 19:47:33]

https://codereview.chromium.org/454993002/diff/1/Source/platform/graphics/Log...
File Source/platform/graphics/LoggingCanvas.h (right):

https://codereview.chromium.org/454993002/diff/1/Source/platform/graphics/Log...
Source/platform/graphics/LoggingCanvas.h:75: virtual void onDrawPicture(const
SkPicture*, const SkMatrix*, const SkPaint*) OVERRIDE;
On 2014/08/08 19:40:22, reed1 wrote:
> On 2014/08/08 19:32:49, danakj wrote:
> > we don't use OVERRIDE on cross-repo (at least for blink) overrides for this
> > reason. maybe now's a good time to stop adding OVERRIDE to things that
> override
> > skia interfaces here.
> 
> If true, that certainly makes it easier for skia.
> 
> I presume you're suggesting I can remove all the overrides in this file? If
so,
> I may do that in a separate CL, to not cloud the intent of this one.

That'd be cool. I was meaning just to not add OVERRIDE here, but ya removing all
would be nice.

[f(malita), 2014-08-08 19:52:01]

rslgtm

[jamesr, 2014-08-08 19:58:46]

I believe the clang checker will require OVERRIDE here (please confirm, though).
 It doesn't require it for blink overrides through a special case that's
currently broken.

[reed2, 2014-08-09 15:32:53]

The CQ bit was checked by reed@chromium.org

[commit-bot: I haz the power, 2014-08-09 15:33:03]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/reed@google.com/454993002/20001

[commit-bot: I haz the power, 2014-08-09 16:35:45]

Change committed as 179885