preemptive add new virtual for onDrawPicture

Source/platform/graphics/LoggingCanvas.h

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 53 matching lines @@
     virtual void onDrawText(const void* text, size_t byteLength, SkScalar x, SkScalar y, const SkPaint&) OVERRIDE;
     virtual void onDrawPosText(const void* text, size_t byteLength, const SkPoint pos[], const SkPaint&) OVERRIDE;
     virtual void onDrawPosTextH(const void* text, size_t byteLength, const SkScalar xpos[], SkScalar constY, const SkPaint&) OVERRIDE;
     virtual void onDrawTextOnPath(const void* text, size_t byteLength, const SkPath&, const SkMatrix*, const SkPaint&) OVERRIDE;
     virtual void onPushCull(const SkRect& cullRect) OVERRIDE;
     virtual void onPopCull() OVERRIDE;
     virtual void onClipRect(const SkRect&, SkRegion::Op, ClipEdgeStyle) OVERRIDE;
     virtual void onClipRRect(const SkRRect&, SkRegion::Op, ClipEdgeStyle) OVERRIDE;
     virtual void onClipPath(const SkPath&, SkRegion::Op, ClipEdgeStyle) OVERRIDE;
     virtual void onClipRegion(const SkRegion&, SkRegion::Op) OVERRIDE;
-    virtual void onDrawPicture(const SkPicture*) OVERRIDE;
+    virtual void onDrawPicture(const SkPicture*);
+    virtual void onDrawPicture(const SkPicture*, const SkMatrix*, const SkPaint*) OVERRIDE;

[danakj, 2014/08/08 19:32:49]

we don't use OVERRIDE on cross-repo (at least for blink) overrides for this
reason. maybe now's a good time to stop adding OVERRIDE to things that override
skia interfaces here.

[reed1, 2014/08/08 19:40:22]

If true, that certainly makes it easier for skia.

I presume you're suggesting I can remove all the overrides in this file? If so,
I may do that in a separate CL, to not cloud the intent of this one.

[danakj, 2014/08/08 19:47:33]

That'd be cool. I was meaning just to not add OVERRIDE here, but ya removing all
would be nice. 

     virtual void didSetMatrix(const SkMatrix&) OVERRIDE;
     virtual void didConcat(const SkMatrix&) OVERRIDE;
     virtual void willSave() OVERRIDE;
     SaveLayerStrategy willSaveLayer(const SkRect* bounds, const SkPaint*, SaveFlags) OVERRIDE;
     virtual void willRestore() OVERRIDE;
 
 private:
     RefPtr<JSONArray> m_log;
     friend class AutoLogger;
 
@@ skipping 48 matching lines @@
     void concat(const SkMatrix&);
     String saveFlagsToString(SkCanvas::SaveFlags);
     String textEncodingCanonicalName(SkPaint::TextEncoding);
     String stringForUTFText(const void* text, size_t length, SkPaint::TextEncoding);
     String stringForText(const void* text, size_t byteLength, const SkPaint&);
 };
 
 }
 
 #endif // LoggingCanvas_h