core/src/fpdfapi/fpdf_font/ttgsubtable.h - Issue 454983003: Add FX_OVERRIDE and use it for virtual functions of FX_FINAL classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fpdfapi/fpdf_font/ttgsubtable.h

Issue 454983003: Add FX_OVERRIDE and use it for virtual functions of FX_FINAL classes. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: mark m_FileAccess private. Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: core/src/fpdfapi/fpdf_font/ttgsubtable.h

diff --git a/core/src/fpdfapi/fpdf_font/ttgsubtable.h b/core/src/fpdfapi/fpdf_font/ttgsubtable.h

index cc7f8c875292d181c05fe4746a2e9c951bd0dc7d..515b9f924251224fd253ce5027db0a3ffa518445 100644

--- a/core/src/fpdfapi/fpdf_font/ttgsubtable.h

+++ b/core/src/fpdfapi/fpdf_font/ttgsubtable.h

@@ -409,11 +409,11 @@ private:

class CFX_GSUBTable FX_FINAL : public IFX_GSUBTable, public CFX_Object

{

public:

- virtual void Release()

+ virtual void Release() FX_OVERRIDE

{

delete this;

}

- virtual FX_BOOL GetVerticalGlyph(FX_DWORD glyphnum, FX_DWORD* vglyphnum);

+ virtual FX_BOOL GetVerticalGlyph(FX_DWORD glyphnum, FX_DWORD* vglyphnum) FX_OVERRIDE;

CFX_CTTGSUBTable m_GsubImp;

};

#endif

« no previous file with comments | « core/include/fxcrt/fx_system.h ('k') | core/src/fxcrt/extension.h » ('j') | no next file with comments »