core/include/fxcrt/fx_system.h - Issue 454983003: Add FX_OVERRIDE and use it for virtual functions of FX_FINAL classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/include/fxcrt/fx_system.h

Issue 454983003: Add FX_OVERRIDE and use it for virtual functions of FX_FINAL classes. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: mark m_FileAccess private. Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: core/include/fxcrt/fx_system.h

diff --git a/core/include/fxcrt/fx_system.h b/core/include/fxcrt/fx_system.h

index 6d659e2c10804ee75a5f528f71f63c897450b8e4..36050f35dcc40dd267fb4074a3c9d555eb54f1b6 100644

--- a/core/include/fxcrt/fx_system.h

+++ b/core/include/fxcrt/fx_system.h

@@ -280,13 +280,17 @@ int FXSYS_round(FX_FLOAT f);

typedef base::CheckedNumeric<FX_DWORD> FX_SAFE_DWORD;

typedef base::CheckedNumeric<FX_INT32> FX_SAFE_INT32;

typedef base::CheckedNumeric<size_t> FX_SAFE_SIZE_T;

#if defined(__clang__) || _MSC_VER >= 1700

#define FX_FINAL final

+#define FX_OVERRIDE override

#elif defined(__GNUC__) && __cplusplus >= 201103 && \

(__GNUC__ * 10000 + __GNUC_MINOR__ * 100) >= 40700

#define FX_FINAL final

+#define FX_OVERRIDE override

#else

#define FX_FINAL

+#define FX_OVERRIDE

#endif

« no previous file with comments | « core/include/fpdfapi/fpdf_parser.h ('k') | core/src/fpdfapi/fpdf_font/ttgsubtable.h » ('j') | no next file with comments »