DescriptionRevert of [Android] Use UIResource for overscroll glow (https://codereview.chromium.org/422013003/)
Reason for revert:
This is breaking chrome ToT downstream and the change quie complex so
I don't feel qualified to try to fix it in place.
The failure we hit is
F/chromium( 2961): [FATAL:system_ui_resource_manager_impl.cc(35)] Check failed: !bitmap.empty().
See an example of a failed run in
https://uberchromegw.corp.google.com/i/clank.tot/builders/instrumentation-yakju-clankium-tot/builds/32007
(but just trying to boot clank with this patch will trigger it)
Original issue's description:
> [Android] Use UIResource for overscroll glow
>
> Introduce a SystemUIResourceManager class for loading and providing access to
> shared UIResourceId's. Wire this class to the existing OverscrollGlow effect,
> using the shared id's with a UIResourceLayer for both glow and edge layers.
>
> This patch is a subset of powei@'s original SystemUIResource patch found at
> https://codereview.chromium.org/377013002/.
>
> BUG=326326
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288095
TBR=aelias@chromium.org,powei@chromium.org,yfriedman@chromium.org,sky@chromium.org,jdduke@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=326326
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288330
Patch Set 1 #
Created: 6 years, 4 months ago
(Patch set is too large to download)
Messages
Total messages: 4 (0 generated)
|