Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(461)

Issue 454863003: Revert of [Android] Use UIResource for overscroll glow (Closed)

Created:
6 years, 4 months ago by Miguel Garcia
Modified:
6 years, 4 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, miu+watch_chromium.org, nona+watch_chromium.org, penghuang+watch_chromium.org, James Su, yukishiino+watch_chromium.org, yusukes+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of [Android] Use UIResource for overscroll glow (https://codereview.chromium.org/422013003/) Reason for revert: This is breaking chrome ToT downstream and the change quie complex so I don't feel qualified to try to fix it in place. The failure we hit is F/chromium( 2961): [FATAL:system_ui_resource_manager_impl.cc(35)] Check failed: !bitmap.empty(). See an example of a failed run in https://uberchromegw.corp.google.com/i/clank.tot/builders/instrumentation-yakju-clankium-tot/builds/32007 (but just trying to boot clank with this patch will trigger it) Original issue's description: > [Android] Use UIResource for overscroll glow > > Introduce a SystemUIResourceManager class for loading and providing access to > shared UIResourceId's. Wire this class to the existing OverscrollGlow effect, > using the shared id's with a UIResourceLayer for both glow and edge layers. > > This patch is a subset of powei@'s original SystemUIResource patch found at > https://codereview.chromium.org/377013002/. > > BUG=326326 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288095 TBR=aelias@chromium.org,powei@chromium.org,yfriedman@chromium.org,sky@chromium.org,jdduke@chromium.org NOTREECHECKS=true NOTRY=true BUG=326326 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288330

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+190 lines, -607 lines) Patch
M content/browser/android/edge_effect.h View 5 chunks +6 lines, -14 lines 0 comments Download
M content/browser/android/edge_effect.cc View 5 chunks +55 lines, -88 lines 0 comments Download
M content/browser/android/overscroll_glow.h View 4 chunks +8 lines, -9 lines 0 comments Download
M content/browser/android/overscroll_glow.cc View 5 chunks +85 lines, -18 lines 0 comments Download
D content/browser/android/system_ui_resource_manager_impl.h View 1 chunk +0 lines, -55 lines 0 comments Download
D content/browser/android/system_ui_resource_manager_impl.cc View 1 chunk +0 lines, -137 lines 0 comments Download
D content/browser/android/system_ui_resource_manager_impl_unittest.cc View 1 chunk +0 lines, -167 lines 0 comments Download
M content/browser/android/ui_resource_provider_impl.h View 2 chunks +1 line, -4 lines 0 comments Download
M content/browser/android/ui_resource_provider_impl.cc View 2 chunks +1 line, -7 lines 0 comments Download
M content/browser/renderer_host/compositor_impl_android.h View 4 chunks +5 lines, -2 lines 0 comments Download
M content/browser/renderer_host/compositor_impl_android.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.cc View 9 chunks +11 lines, -27 lines 0 comments Download
M content/content_browser.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M content/content_tests.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M ui/base/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D ui/base/android/system_ui_resource_manager.h View 1 chunk +0 lines, -41 lines 0 comments Download
M ui/base/android/window_android_compositor.h View 2 chunks +0 lines, -2 lines 0 comments Download
M ui/base/ui_base.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M ui/gfx/android/java_bitmap.h View 1 chunk +6 lines, -6 lines 0 comments Download
M ui/gfx/android/java_bitmap.cc View 3 chunks +11 lines, -21 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Miguel Garcia
Created Revert of [Android] Use UIResource for overscroll glow
6 years, 4 months ago (2014-08-08 10:57:14 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/miguelg@chromium.org/454863003/1
6 years, 4 months ago (2014-08-08 10:59:50 UTC) #2
commit-bot: I haz the power
Change committed as 288330
6 years, 4 months ago (2014-08-08 11:10:56 UTC) #3
jdduke (slow)
6 years, 4 months ago (2014-08-08 18:07:11 UTC) #4
Message was sent while issue was closed.
A revert of this CL has been created in
https://codereview.chromium.org/454113002/ by jdduke@chromium.org.

The reason for reverting is: The ToT builder failures appear to be unrelated to
this change, and the
upstream instrumentation already exercise these code paths. Tentatively
reverting the revert and will keep an eye on downstream rolls..

Powered by Google App Engine
This is Rietveld 408576698