Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 454843004: Fixes for the missing highlights. (Closed)

Created:
6 years, 4 months ago by scheglov
Modified:
6 years, 4 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Remove unused function #

Unified diffs Side-by-side diffs Delta from patch set Stats (+332 lines, -76 lines) Patch
M pkg/analysis_server/lib/src/computer/computer_highlights.dart View 1 18 chunks +204 lines, -67 lines 0 comments Download
M pkg/analysis_server/test/analysis_abstract.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analysis_server/test/analysis_notification_highlights_test.dart View 9 chunks +127 lines, -9 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
scheglov
6 years, 4 months ago (2014-08-12 02:22:36 UTC) #1
Paul Berry
lgtm
6 years, 4 months ago (2014-08-12 12:04:21 UTC) #2
Brian Wilkerson
LGTM
6 years, 4 months ago (2014-08-12 13:31:41 UTC) #3
scheglov
6 years, 4 months ago (2014-08-12 14:24:06 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as 39140 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698