Issue 454823002: Revert 288164 "Roll gtest and gmock DEPS."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 454823002: Revert 288164 "Roll gtest and gmock DEPS." (Closed)

Created:
6 years, 4 months ago by tommi (sloooow) - chröme

Modified:
6 years, 4 months ago

Reviewers:
Nick Bray (chromium)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

Description

Revert 288164 "Roll gtest and gmock DEPS." Suspected to have broken the Chrome Win build: c:\b\build\slave\google-chrome-rel-win\build\src\base\numerics\safe_numerics_unittest.cc(577) : error C2220: warning treated as error - no 'object' file generated c:\b\build\slave\google-chrome-rel-win\build\src\base\numerics\safe_numerics_unittest.cc(577) : warning C4756: overflow in constant arithmetic > Roll gtest and gmock DEPS. > > These DEPS have not been updated for ~2 years, so there is a good chance > something will blow up. Due to interdependancy between the repos, > rolling gtest required gmock also be rolled. > > BUG=none > > Review URL: https://codereview.chromium.org/425333002 TBR=ncbray@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288239

Patch Set 1 #

Created: 6 years, 4 months ago

	Unified diffs	Side-by-side diffs	Stats (+2 lines, -8 lines)
M	trunk/src/DEPS	View	1 chunk	+2 lines, -2 lines	0 comments
M	trunk/src/build/secondary/testing/gtest/BUILD.gn	View	1 chunk	+0 lines, -2 lines	0 comments
M	trunk/src/native_client_sdk/src/libraries/gmock/library.dsc	View	1 chunk	+0 lines, -1 line	0 comments
M	trunk/src/testing/gtest.gyp	View	1 chunk	+0 lines, -3 lines	0 comments

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

tommi (sloooow) - chröme

Committed patchset #1 manually as r288239 (tree was closed).

6 years, 4 months ago (2014-08-08 07:57:26 UTC) #2

Nick Bray (chromium)

6 years, 4 months ago (2014-08-08 19:43:59 UTC) #3

Message was sent while issue was closed.

LGTM, it looks like it's a valid warning revealed only when LTO is enabled for
MSVS.

Expand Messages | Collapse Messages