Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Issue 425333002: Roll gtest and gmock DEPS. (Closed)

Created:
6 years, 4 months ago by Nick Bray (chromium)
Modified:
6 years, 4 months ago
CC:
chromium-reviews, Avi (use Gerrit), tfarina, Nico
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Roll gtest and gmock DEPS. These DEPS have not been updated for ~2 years, so there is a good chance something will blow up. Due to interdependancy between the repos, rolling gtest required gmock also be rolled. This CL was originally landed as 288164 and reverted as 288239 because it allows more aggressive LTO in MSVS. This resulted in the compiler noticing an intentional arithmetic overflow and warning about it. BUG=401761 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288505

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : SDK fix #

Patch Set 4 : GN Fix #

Patch Set 5 : Numeric fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -2 lines) Patch
M DEPS View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M base/numerics/safe_numerics_unittest.cc View 1 2 3 4 1 chunk +7 lines, -0 lines 0 comments Download
M build/secondary/testing/gtest/BUILD.gn View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M native_client_sdk/src/libraries/gmock/library.dsc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M testing/gtest.gyp View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
Nick Bray (chromium)
Last time the DEPS were rolled, it was reverted due to incompletely documented reasons on ...
6 years, 4 months ago (2014-07-30 18:37:00 UTC) #1
bradn
lgtm
6 years, 4 months ago (2014-07-30 18:46:57 UTC) #2
tfarina
Last time I tried things didn't go fine: https://codereview.chromium.org/149243010/ https://codereview.chromium.org/131233008/
6 years, 4 months ago (2014-07-30 18:57:56 UTC) #3
Nick Bray (chromium)
Blocked on: https://codereview.chromium.org/429793003/ https://codereview.chromium.org/431533003/
6 years, 4 months ago (2014-07-30 22:22:37 UTC) #4
Nick Bray (chromium)
The CQ bit was checked by ncbray@chromium.org
6 years, 4 months ago (2014-08-06 22:09:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ncbray@chromium.org/425333002/40001
6 years, 4 months ago (2014-08-06 22:12:01 UTC) #6
binji
native_client_sdk lgtm
6 years, 4 months ago (2014-08-06 23:30:03 UTC) #7
Nick Bray (chromium)
The CQ bit was checked by ncbray@chromium.org
6 years, 4 months ago (2014-08-07 17:13:57 UTC) #8
Nick Bray (chromium)
The CQ bit was unchecked by ncbray@chromium.org
6 years, 4 months ago (2014-08-07 17:14:00 UTC) #9
Nick Bray (chromium)
The CQ bit was checked by ncbray@chromium.org
6 years, 4 months ago (2014-08-07 17:56:01 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ncbray@chromium.org/425333002/60001
6 years, 4 months ago (2014-08-07 18:09:15 UTC) #11
commit-bot: I haz the power
Change committed as 288164
6 years, 4 months ago (2014-08-07 23:41:02 UTC) #12
Lei Zhang
I think this might have broken safe_numerics_unittest.cc on the "Google Chrome Win" bot.
6 years, 4 months ago (2014-08-08 07:26:32 UTC) #13
chromium-reviews
I've reverted the change. I'll reland if this wasn't the reason for the breakage. On ...
6 years, 4 months ago (2014-08-08 07:58:05 UTC) #14
Nick Bray (chromium)
Reopened and uploaded patch to fix breakage. +jschuh for OWNERs review. Please check the CQ ...
6 years, 4 months ago (2014-08-08 19:54:13 UTC) #15
jschuh
lgtm
6 years, 4 months ago (2014-08-08 19:58:46 UTC) #16
commit-bot: I haz the power
6 years, 4 months ago (2014-08-09 05:24:17 UTC) #17
Message was sent while issue was closed.
Change committed as 288505

Powered by Google App Engine
This is Rietveld 408576698