Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(835)

Issue 454583002: Cleanup: Remove unneeded #includes for grit/, ui/base/l10n/l10n_util.h and ui/base/resource/resourc… (Closed)

Created:
6 years, 4 months ago by Lei Zhang
Modified:
6 years, 4 months ago
Reviewers:
Nico
CC:
chromium-reviews, asanka, dbeam+watch-options_chromium.org, skanuj+watch_chromium.org, felt, yusukes+watch_chromium.org, zea+watch_chromium.org, tzik, dhollowa+watch_chromium.org, dougw+watch_chromium.org, browser-components-watch_chromium.org, yukishiino+watch_chromium.org, dmazzoni+watch_chromium.org, markusheintz_, stevenjb+watch_chromium.org, mkwst+watchlist_chromium.org, nkostylev+watch_chromium.org, tim+watch_chromium.org, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, benquan, melevin+watch_chromium.org, aboxhall+watch_chromium.org, Ilya Sherman, dyu1, dominich, nona+watch_chromium.org, rlp+watch_chromium.org, rouslan+autofillwatch_chromium.org, kinuko+fileapi, groby+spellwatch_chromium.org, chromium-apps-reviews_chromium.org, pedrosimonetti+watch_chromium.org, dbeam+watch-ntp_chromium.org, samarth+watch_chromium.org, tbarzic+watch_chromium.org, haitaol+watch_chromium.org, rouslan+spellwatch_chromium.org, yuzo+watch_chromium.org, feature-media-reviews_chromium.org, jfweitz+watch_chromium.org, pam+watch_chromium.org, nhiroki, oshima+watch_chromium.org, estade+watch_chromium.org, gcasto+watchlist_chromium.org, Jered, maniscalco+watch_chromium.org, chrome-apps-syd-reviews_chromium.org, plundblad+watch_chromium.org, tfarina, donnd+watch_chromium.org, mmenke, benjhayden+dwatch_chromium.org, eroman, David Black, Dane Wallinga, dtseng+watch_chromium.org, kmadhusu+watch_chromium.org, James Su, jshin+watch_chromium.org, davemoore+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Cleanup: Remove unneeded #includes for grit/, ui/base/l10n/l10n_util.h and ui/base/resource/resource_bundle.h. For files that have #include from the list above, the heuristics for determining if the #includes are needed are as follows: grit -> with a few exceptions, grep for ID[RS] l10n_util.h -> grep l10n_util:: resource_bundle.h -> egrep '(GetImageNamed|GetNativeImageNamed|GetRawDataResource|GetLocalizedString|GetImageSkiaNamed|ResourceBundle)' Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288450

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Fix CrOS #

Patch Set 4 : Fix Mac #

Patch Set 5 : Fix Cros/Mac some more #

Patch Set 6 : Fix Cros some more #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -267 lines) Patch
M chrome/app/chrome_main_delegate.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/browser/android/omnibox/autocomplete_controller_android.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/android/provider/chrome_browser_provider.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/chrome_browser_main_android.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/accessibility/accessibility_manager.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/chrome_browser_main_chromeos.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/imageburner/burn_controller.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/input_method/input_method_util_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/auth/login_performer.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/existing_user_controller_browsertest.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/helper.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/lock/screen_locker.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/lock/webui_screen_locker.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/screens/network_screen.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/screens/user_image_screen.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager_unittest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/version_info_updater.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/wizard_controller.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/net/network_portal_detector_impl.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/offline/offline_load_page.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/options/vpn_config_view.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/profiles/profile_list_chromeos_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/set_time_dialog.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/ui/screen_capture_notification_ui_chromeos.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/ui_proxy_config_service.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/content_settings/permission_context_base.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/diagnostics/diagnostics_writer.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/download/download_file_picker.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/download/download_item_model_unittest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/download/download_status_updater_win.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/extensions/activity_log/ad_network_database.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/identity/identity_apitest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/tabs/tabs_api.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/webstore_private/webstore_private_api.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/extensions/bookmark_app_helper.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/crx_installer.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/default_apps.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_message_bubble_controller.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_uninstall_dialog.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/history/history_service.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/infobars/infobar_extension_api.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/notifications/desktop_notification_service.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/platform_util_mac.mm View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/policy/configuration_policy_handler_list_factory.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/policy/managed_bookmarks_policy_handler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/printing/cloud_print/cloud_print_proxy_service.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/profiles/incognito_mode_policy_handler_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/profiles/profile_avatar_icon_util.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/search/iframe_source.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/search/search.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/signin/signin_promo.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/speech/extension_api/tts_engine_extension_observer.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/status_icons/status_icon_menu_model.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/supervised_user/supervised_user_browsertest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/sync/sync_ui_util.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/task_manager/printing_information.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/android/autofill/autofill_dialog_controller_android.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/android/autofill/autofill_dialog_result.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/android/infobars/translate_infobar.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/app_list/search/people/person.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/autofill/account_chooser_model.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/autofill/autofill_dialog_models.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/autofill/autofill_dialog_types.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/autofill/password_generation_popup_controller_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/bookmarks/bookmark_context_menu_controller_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/autofill/autofill_dialog_window_controller.mm View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/autofill/autofill_main_container.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/autofill/autofill_popup_view_cocoa.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/autofill/autofill_section_container_unittest.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/autofill/password_generation_popup_view_cocoa.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/base_bubble_controller.mm View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_toolbar_view.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_toolbar_view_unittest.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_editor_controller.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/browser_window_cocoa.mm View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/content_settings/cookie_details_view_controller.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/download/download_item_cell.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/download/download_shelf_controller.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/download/download_shelf_view.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/extensions/browser_action_button.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_uninstall_dialog_cocoa.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/extensions/media_galleries_dialog_cocoa.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/first_run_bubble_controller.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/first_run_dialog.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/global_error_bubble_controller.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/image_button_cell.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell_unittest.mm View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_unittest.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/location_bar/generated_credit_card_decoration.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/location_bar/origin_chip_decoration.mm View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/search_button_decoration.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/login_prompt_cocoa.mm View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/profiles/avatar_base_controller.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/profiles/avatar_label_button.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/profiles/avatar_label_button_unittest.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/styled_text_field_cell.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_controller.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/website_settings/split_block_button.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/website_settings/split_block_button.mm View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/extensions/application_launch.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/extensions/extension_install_ui_default.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/search/instant_extended_interactive_uitest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/search/search_ui.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/startup/startup_browser_creator.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/startup/startup_browser_creator_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/sync/one_click_signin_helper.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/sync/one_click_signin_sync_starter.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/toolbar/recent_tabs_sub_menu_model_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/toolbar/wrench_menu_model_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/apps/app_window_desktop_window_tree_host_win.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/autofill/autofill_dialog_views.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/autofill/autofill_popup_view_views.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_bar_view_test.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_context_menu.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_context_menu_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_menu_controller_views.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/download/download_in_progress_dialog_view.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/frame/browser_desktop_window_tree_host_win.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/frame/browser_non_client_frame_view.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/frame/browser_view_unittest.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/frame/desktop_browser_frame_aura.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/frame/glass_browser_frame_view.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/location_bar/icon_label_bubble_view.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/location_bar/origin_chip_view.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/message_center/web_notification_tray_win.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_view_views.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/open_pdf_in_reader_bubble_view.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/profiles/avatar_menu_button_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/profiles/new_avatar_menu_button_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/profiles/profile_chooser_view_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/session_crashed_bubble_view.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/tab_modal_confirm_dialog_views.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/translate/translate_bubble_view.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/website_settings/website_settings.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/choose_mobile_network_ui.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/keyboard_overlay_ui.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/reset_screen_handler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/slow_trace_ui.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/slow_ui.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/crashes_ui.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/downloads_dom_handler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/extensions/extension_settings_handler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/fileicon_source.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/flash_ui.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/help/help_handler.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/interstitials/interstitial_ui.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/media/webrtc_logs_ui.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/nacl_ui.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/net_internals/net_internals_ui.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/ntp/favicon_webui_handler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/ntp/most_visited_handler.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/ntp/new_tab_page_handler.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/ntp/thumbnail_source.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/bluetooth_options_handler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/options/chromeos/proxy_handler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/options/cookies_view_handler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/options/handler_options_handler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/options/home_page_overlay_handler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/options/import_data_handler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/options/media_devices_selection_handler.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/options/media_devices_selection_handler.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/webui/options/password_manager_handler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/options/reset_profile_settings_handler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/options/supervised_user_create_confirm_handler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/options/supervised_user_import_handler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/quota_internals/quota_internals_ui.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/signin/profile_signin_confirmation_ui.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/signin_internals_ui.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/sync_file_system_internals/extension_statuses_handler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/sync_file_system_internals/file_metadata_handler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/sync_internals_ui.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/sync_setup_handler_unittest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/translate_internals/translate_internals_ui.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/undo/bookmark_undo_service.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/upgrade_detector_impl.cc View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/chrome_version_info.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/extensions/manifest_handlers/settings_overrides_handler.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_homepage_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/extensions/extension_localization_peer.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/renderer/safe_browsing/phishing_term_feature_extractor.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/renderer/searchbox/searchbox.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/renderer/spellchecker/spellcheck_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/renderer/web_apps.cc View 2 chunks +1 line, -4 lines 0 comments Download
M chrome/service/cloud_print/cloud_print_proxy_backend.cc View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/service/cloud_print/print_system_cups.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/service/cloud_print/print_system_win.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
Lei Zhang
grit -> with a few exceptions, grep for ID[RS] l10n_util.h -> grep l10n_util:: resource_bundle.h -> ...
6 years, 4 months ago (2014-08-07 22:38:34 UTC) #1
Nico
lgtm, awesome!! (nit: I'd copy the text from your rietveld comment into the CL description) ...
6 years, 4 months ago (2014-08-07 22:41:16 UTC) #2
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 4 months ago (2014-08-08 05:04:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/454583002/100001
6 years, 4 months ago (2014-08-08 05:06:17 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-08 09:21:37 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-08 09:26:29 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/2862)
6 years, 4 months ago (2014-08-08 09:26:31 UTC) #7
Nico
https://codereview.chromium.org/458503002 for the presubmit failure
6 years, 4 months ago (2014-08-08 16:15:35 UTC) #8
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 4 months ago (2014-08-08 21:39:52 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/454583002/100001
6 years, 4 months ago (2014-08-08 21:42:38 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-08 21:50:47 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-08 21:56:42 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/3043)
6 years, 4 months ago (2014-08-08 21:56:47 UTC) #13
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 4 months ago (2014-08-08 22:07:40 UTC) #14
Nico
The CQ bit was checked by thakis@chromium.org
6 years, 4 months ago (2014-08-08 22:07:41 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/454583002/100001
6 years, 4 months ago (2014-08-08 22:09:21 UTC) #16
commit-bot: I haz the power
6 years, 4 months ago (2014-08-08 22:44:13 UTC) #17
Message was sent while issue was closed.
Change committed as 288450

Powered by Google App Engine
This is Rietveld 408576698