Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(992)

Issue 4544004: Fix bubble offset issue (bubble x-coordinate pointing to wrong place) on OS X... (Closed)

Created:
10 years, 1 month ago by Miranda Callahan
Modified:
9 years, 7 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews, pam+watch_chromium.org, ben+cc_chromium.org
Visibility:
Public.

Description

Fix bubble offset issue (bubble x-coordinate pointing to wrong place) on OS X. BUG=60576 TEST=first run bubble, cookies blocked bubble, + geolocation bubble all point to correct place. as do all other bubbles. NOTE: correct location for the first run bubble is to have its left side aligned with the left side of the omnibox. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=65452

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -18 lines) Patch
M chrome/browser/cocoa/base_bubble_controller.mm View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/cocoa/location_bar/location_bar_view_mac.mm View 1 2 3 chunks +9 lines, -17 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Miranda Callahan
This fixes an issue in the basebubblecontroller -- the arrow offset should be subtracted from ...
10 years, 1 month ago (2010-11-08 21:47:40 UTC) #1
Robert Sesek
10 years, 1 month ago (2010-11-08 22:04:33 UTC) #2
LGTM!

Powered by Google App Engine
This is Rietveld 408576698