chrome/browser/cocoa/base_bubble_controller.mm - Issue 4544004: Fix bubble offset issue (bubble x-coordinate pointing to wrong place) on OS X...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/cocoa/base_bubble_controller.mm

Issue 4544004: Fix bubble offset issue (bubble x-coordinate pointing to wrong place) on OS X... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: '' Created 10 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/cocoa/base_bubble_controller.mm

===================================================================

--- chrome/browser/cocoa/base_bubble_controller.mm (revision 65381)

+++ chrome/browser/cocoa/base_bubble_controller.mm (working copy)

@@ -190,7 +190,7 @@

info_bubble::kBubbleArrowWidth / 2.0, 0);

offsets = [[parentWindow_ contentView] convertSize:offsets toView:nil];

if ([bubble_ arrowLocation] == info_bubble::kTopRight) {

- origin.x -= NSWidth([window frame]) + offsets.width;

+ origin.x -= NSWidth([window frame]) - offsets.width;

} else {

origin.x -= offsets.width;

}

« no previous file with comments | « no previous file | chrome/browser/cocoa/location_bar/location_bar_view_mac.mm » ('j') | no next file with comments »