chrome/browser/geolocation/geolocation_permission_context_unittest.cc - Issue 454253002: Location chooser

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/geolocation/geolocation_permission_context_unittest.cc

Issue 454253002: Location chooser (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressing meacer@ comments Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/geolocation/geolocation_permission_context.cc ('K') | « chrome/browser/geolocation/geolocation_permission_context_extensions.cc ('k') | chrome/browser/guest_view/web_view/web_view_permission_helper.h » ('j') | chrome/browser/ui/views/website_settings/permissions_bubble_view.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/geolocation/geolocation_permission_context_unittest.cc

diff --git a/chrome/browser/geolocation/geolocation_permission_context_unittest.cc b/chrome/browser/geolocation/geolocation_permission_context_unittest.cc

index 9ae3a305414dee56dd96abfacef9508e28c93f37..437f43c5ee91c001352ddb9f2cecfb496eb4376d 100644

--- a/chrome/browser/geolocation/geolocation_permission_context_unittest.cc

+++ b/chrome/browser/geolocation/geolocation_permission_context_unittest.cc

@@ -124,7 +124,8 @@ class GeolocationPermissionContextTests

const GURL& requesting_frame,

base::Closure* cancel_callback);

void PermissionResponse(const PermissionRequestID& id,

- bool allowed);

+ bool allowed,

+ int choice);

void CheckPermissionMessageSent(int bridge_id, bool allowed);

void CheckPermissionMessageSentForTab(int tab, int bridge_id, bool allowed);

void CheckPermissionMessageSentInternal(MockRenderProcessHost* process,

@@ -185,7 +186,9 @@ void GeolocationPermissionContextTests::RequestGeolocationPermission(

void GeolocationPermissionContextTests::PermissionResponse(

const PermissionRequestID& id,

- bool allowed) {

+ bool allowed,

+ int choice) {

+ // (mohammed) test choice.

meacer 2014/08/15 23:34:46 nit: TODO(mohammed):

responses_[id.render_process_id()] = std::make_pair(id.bridge_id(), allowed);

}