chrome/browser/geolocation/geolocation_permission_context_extensions.cc - Issue 454253002: Location chooser

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/geolocation/geolocation_permission_context_extensions.cc

Issue 454253002: Location chooser (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressing meacer@ comments Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/geolocation/geolocation_permission_context.cc ('K') | « chrome/browser/geolocation/geolocation_permission_context_extensions.h ('k') | chrome/browser/geolocation/geolocation_permission_context_unittest.cc » ('j') | chrome/browser/geolocation/geolocation_permission_context_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/geolocation/geolocation_permission_context_extensions.cc

diff --git a/chrome/browser/geolocation/geolocation_permission_context_extensions.cc b/chrome/browser/geolocation/geolocation_permission_context_extensions.cc

index e0496b19cb94ff64d90100ec16c05fbb4ae5cc05..7ced6d60a449f12e20e74d5c6efe29ae3e29f9fe 100644

--- a/chrome/browser/geolocation/geolocation_permission_context_extensions.cc

+++ b/chrome/browser/geolocation/geolocation_permission_context_extensions.cc

@@ -35,7 +35,7 @@ bool GeolocationPermissionContextExtensions::RequestPermission(

int bridge_id,

const GURL& requesting_frame,

bool user_gesture,

- base::Callback<void(bool)> callback,

+ base::Callback<void(int, bool)> callback,

bool* permission_set,

bool* new_permission) {

#if defined(ENABLE_EXTENSIONS)