Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6006)

Unified Diff: chrome/test/chromedriver/logging_unittest.cc

Issue 454133003: [ChromeDriver] Implementing tracing support (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixing nits Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/chromedriver/logging.cc ('k') | chrome/test/chromedriver/performance_logger.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/chromedriver/logging_unittest.cc
diff --git a/chrome/test/chromedriver/logging_unittest.cc b/chrome/test/chromedriver/logging_unittest.cc
index 53b627bf4331b3f55d65182dcdfd91cbe5d358f2..29e363994f9f53b9c57e3c101f8b3ced713c631c 100644
--- a/chrome/test/chromedriver/logging_unittest.cc
+++ b/chrome/test/chromedriver/logging_unittest.cc
@@ -9,6 +9,7 @@
#include "chrome/test/chromedriver/chrome/status.h"
#include "chrome/test/chromedriver/command_listener.h"
#include "chrome/test/chromedriver/logging.h"
+#include "chrome/test/chromedriver/session.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace {
@@ -99,13 +100,14 @@ TEST(WebDriverLog, All) {
TEST(Logging, CreatePerformanceLog) {
Capabilities capabilities;
+ Session session("test");
capabilities.logging_prefs["performance"] = Log::kInfo;
capabilities.logging_prefs["browser"] = Log::kInfo;
ScopedVector<DevToolsEventListener> devtools_listeners;
ScopedVector<WebDriverLog> logs;
ScopedVector<CommandListener> command_listeners;
- Status status = CreateLogs(capabilities, &logs, &devtools_listeners,
+ Status status = CreateLogs(capabilities, &session, &logs, &devtools_listeners,
&command_listeners);
ASSERT_TRUE(status.IsOk());
ASSERT_EQ(2u, logs.size());
@@ -117,12 +119,13 @@ TEST(Logging, CreatePerformanceLog) {
TEST(Logging, IgnoreUnknownLogType) {
Capabilities capabilities;
+ Session session("test");
capabilities.logging_prefs["gaga"] = Log::kInfo;
ScopedVector<DevToolsEventListener> devtools_listeners;
ScopedVector<WebDriverLog> logs;
ScopedVector<CommandListener> command_listeners;
- Status status = CreateLogs(capabilities, &logs, &devtools_listeners,
+ Status status = CreateLogs(capabilities, &session, &logs, &devtools_listeners,
&command_listeners);
EXPECT_TRUE(status.IsOk());
ASSERT_EQ(1u, logs.size());
@@ -133,11 +136,12 @@ TEST(Logging, IgnoreUnknownLogType) {
TEST(Logging, DefaultLogs) {
Capabilities capabilities;
+ Session session("test");
ScopedVector<DevToolsEventListener> devtools_listeners;
ScopedVector<WebDriverLog> logs;
ScopedVector<CommandListener> command_listeners;
- Status status = CreateLogs(capabilities, &logs, &devtools_listeners,
+ Status status = CreateLogs(capabilities, &session, &logs, &devtools_listeners,
&command_listeners);
EXPECT_TRUE(status.IsOk());
ASSERT_EQ(1u, logs.size());
« no previous file with comments | « chrome/test/chromedriver/logging.cc ('k') | chrome/test/chromedriver/performance_logger.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698